fix: vale check #474
Merged
fix: vale check #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
github-actions
bot
added
the
bug
SMoraisAnsys
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
LGTM but I'm a bit confused with the changes and the current main branch.
Did afb1380 got pushed before this PR ? I may be missing something but they seem to be the same changes.
|
The PR is not working properly. I reverted the commit and re-opened it. We need to fix the if statement. |
RobPasMue
commented
Apr 25, 2024
RobPasMue
commented
Apr 25, 2024
RobPasMue
commented
Apr 25, 2024
|
Okay - now it works like a charm. Testing performed here: ansys/pyansys-geometry#1168 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting #470 commited to main - if is failing. See https://github.com/ansys/actions/actions/runs/8833187453/job/24251985324