Fix GitHub release #276
Fix GitHub release #276
Conversation
ludovicsteinbach
commented
Mar 14, 2023
•
ludovicsteinbach
commented
- Fix docs url in pyproject
- Fix condition for dev docs deploy
- Fix gh release step: see https://github.com/pyansys/grantami-bomanalytics/releases/tag/untagged-bb564b6493b96d77faba, generated in CI before putting some conditions back
Codecov Report
@@ Coverage Diff @@
## main #276 +/- ##
=======================================
Coverage 95.32% 95.32%
=======================================
Files 10 10
Lines 1369 1369
=======================================
Hits 1305 1305
Misses 64 64 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| name: Documentation-html | ||
| path: ~/dist | ||
|
|
||
| - name: "Compressing HTML documentation" |
There was a problem hiding this comment.
You shouldn't need to explicitely zip artifacts, if you mark a folder for upload then it should be zipped by default
There was a problem hiding this comment.
Wouldn't downloading it unzip it then?
Edit: I think I misunderstood you. Do you mean the artifact should be zipped already or when using the release action pointing it at a folder should zip it?
There was a problem hiding this comment.
All seems good, and the draft release looks right. I don't see anything in the release docs https://github.com/softprops/action-gh-release that explicitly states that it will zip a folder, but it would be nicer if we didn't need to rely on any more actions than absolutely necessary.
.github/workflows/ci_cd.yml
Outdated
| @@ -91,8 +103,11 @@ jobs: | |||
| - name: Release | |||
| uses: softprops/action-gh-release@v1 | |||
| with: | |||
| prerelease: true | |||
There was a problem hiding this comment.
Presumably these three additions will be removed before merge.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
* Fix job dependency * Disable conditions and unwanted release steps * DL artifacts and add to rlelease * Fix paths * Revert "Disable conditions and unwanted release steps" This reverts commit 3afd2dc. * Fix condition for dev docs deploy * Update documentation path * Remove extra args in gh release
