generated from ansys/template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GitHub release #276
Merged
Merged
Fix GitHub release #276
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9e453ea
Fix job dependency
ludovicsteinbach 3afd2dc
Disable conditions and unwanted release steps
ludovicsteinbach 48ebca2
DL artifacts and add to rlelease
ludovicsteinbach eea7448
Fix paths
ludovicsteinbach 15c856d
Revert "Disable conditions and unwanted release steps"
ludovicsteinbach 7caa4a0
Fix condition for dev docs deploy
ludovicsteinbach 0d9a6be
Update documentation path
ludovicsteinbach 414b9a6
Remove extra args in gh release
ludovicsteinbach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,7 +43,7 @@ jobs: | |
name: "Deploy development documentation" | ||
runs-on: ubuntu-latest | ||
needs: [ integration_checks ] | ||
if: github.event_name == 'push' | ||
if: github.event_name == 'push' && !contains(github.ref, 'refs/tags') | ||
steps: | ||
- uses: pyansys/actions/doc-deploy-dev@v4 | ||
with: | ||
|
@@ -53,7 +53,7 @@ jobs: | |
|
||
Release: | ||
if: contains(github.ref, 'refs/tags') && github.event_name == 'push' | ||
needs: doc-deploy-dev | ||
needs: integration_checks | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v3 | ||
|
@@ -66,11 +66,23 @@ jobs: | |
- uses: actions/download-artifact@v3 | ||
with: | ||
name: ansys-grantami-bomanalytics-wheel | ||
path: ~/dist | ||
path: dist | ||
|
||
- uses: actions/download-artifact@v3 | ||
with: | ||
name: Documentation-pdf | ||
path: dist | ||
|
||
- uses: actions/download-artifact@v3 | ||
with: | ||
name: Documentation-html | ||
path: dist/documentation-html/ | ||
|
||
- name: "Compressing HTML documentation" | ||
uses: vimtor/action-zip@v1.1 | ||
with: | ||
files: dist/documentation-html/ | ||
dest: dist/documentation-html.zip | ||
|
||
- name: "Deploy stable documentation" | ||
uses: pyansys/actions/doc-deploy-stable@v4 | ||
|
@@ -91,8 +103,11 @@ jobs: | |
- name: Release | ||
uses: softprops/action-gh-release@v1 | ||
with: | ||
prerelease: true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Presumably these three additions will be removed before merge. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Indeed |
||
tag_name: v1.1.3b0 | ||
draft: true | ||
generate_release_notes: true | ||
files: | | ||
~/**/*.whl | ||
./**/*.zip | ||
dist/*.whl | ||
dist/documentation-html.zip | ||
dist/*.pdf |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't need to explicitely zip artifacts, if you mark a folder for upload then it should be zipped by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't downloading it unzip it then?
Edit: I think I misunderstood you. Do you mean the artifact should be zipped already or when using the release action pointing it at a folder should zip it?