Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cycles_to_failure as proposed by McMunich #224

Closed
wants to merge 7 commits into from

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Apr 25, 2022

Copy of #223 using a branch of a cloned repo so that pipelines can run.

@PProfizi
Copy link
Contributor Author

PProfizi commented Apr 25, 2022

@mcMunich I have made a PR as contributor so that the pipelines can run.
I just took your example and pushed it via a branch of a cloned repository (and not a forked repository).
This is the way to contribute as of today for PyAnsys projects.
Tested it locally, it works. I guess personally I would need more explanations as to what is happening to totally understand the result at the end ;)
Right now the pipeline for building the doc fails because pyMAPDL is not installed in our pipelines. TBC

@PProfizi PProfizi self-assigned this Apr 25, 2022
@PProfizi PProfizi added the documentation Improvements or additions to documentation label Apr 25, 2022
@PProfizi
Copy link
Contributor Author

Started an Issue with necessary improvements to the pipelines (#225)

@mcMunich
Copy link
Collaborator

mcMunich commented Apr 25, 2022

@mcMunich I have made a PR as contributor so that the pipelines can run. I just took your example and pushed it via a branch of a cloned repository (and not a forked repository). This is the way to contribute as of today for PyAnsys projects. Tested it locally, it works. I guess personally I would need more explanations as to what is happening to totally understand the result at the end ;) Right now the pipeline for building the doc fails because pyMAPDL is not installed in our pipelines. TBC

@PProfizi Agreed, I didn't want to overdocument and then have to edit it away. I can add some clarity when I figure out how that works.

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #224 (22be521) into master (4e7d7d5) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
- Coverage   86.22%   86.19%   -0.04%     
==========================================
  Files          52       52              
  Lines        5661     5663       +2     
==========================================
  Hits         4881     4881              
- Misses        780      782       +2     

@PProfizi
Copy link
Contributor Author

PProfizi commented Jul 5, 2022

Waiting for ansys/example-data#44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants