-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: improve examples #609
Conversation
examples/04-specific-requests/00-hdf5_double_float_comparison.py
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #609 +/- ##
==========================================
+ Coverage 87.90% 88.02% +0.11%
==========================================
Files 68 69 +1
Lines 7566 7623 +57
==========================================
+ Hits 6651 6710 +59
+ Misses 915 913 -2 |
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @GuillemBarroso for taking time to review and work with all those examples.
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
@GuillemBarroso For the last Codacy warning remaining, I am basing my fix on this page: https://security.openstack.org/guidelines/dg_use-subprocess-securely.html |
Great, thanks @PProfizi. I am rerunning the only check that failed and as soon as it passes, we can merge. |
@@ -1,3 +1,4 @@ | |||
# noqa: D400 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GuillemBarroso What is that skipping for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improvements in the example section.
@PProfizi, @MaxJPRey, feedback will be greatly appreciated.