-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: improve examples #609
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
a032135
Improve 00-basic_example.py
GuillemBarroso 5aab8a8
Improve 01-basic_operators.py
GuillemBarroso 711f5fc
Improve 02-basic_field_containers.py
GuillemBarroso 66c2f7d
Improve 03-create_entities.py
GuillemBarroso 238ce6a
Improve 04-basic-load-file.py
GuillemBarroso e662172
Improve 07-use_result_helpers
GuillemBarroso 50ce5fb
Improve 08-results_over_time_subset
GuillemBarroso b6aab4f
Improve 09-results_over_space_subset
GuillemBarroso 8e9e969
Improve 11-server_types
GuillemBarroso 7eb4239
Improve 13-nodes_in_local_coordinate_system
GuillemBarroso 8ff7971
Improve 00-basic_transient
GuillemBarroso 2fe9df9
Improve 01-transient_easy_time_scoping
GuillemBarroso fc9d260
Improve plots in 04-basic-load-file
GuillemBarroso ef2acd9
Improve 01-modal_cyclic
GuillemBarroso cec0ee9
Improve 02-cyclic_multi_stage
GuillemBarroso 295dc2c
Improve 03-compare_modes
GuillemBarroso 4960301
Improve 03-exchange_data_between_servers
GuillemBarroso f2ee538
Improve 04-extrapolation_stress_3d
GuillemBarroso 0308db8
05-extrapolation_strain_2d
GuillemBarroso dd329f1
Improve 06-stress_gradient_path
GuillemBarroso f4c80ab
Improve 00-hdf5_double_float_comparison
GuillemBarroso 479e413
Improve 02-solution_combination
GuillemBarroso d5f5ee4
Improve 04-plot_on_path
GuillemBarroso d71df8f
Improve 01-package_python_operators
GuillemBarroso 2c8e963
Improve 02-python_operators_with_dependencies
GuillemBarroso 5cb27e5
Fix style check
GuillemBarroso 583c462
Apply suggestions from code review
GuillemBarroso 26e22b9
Apply suggestions from code review
GuillemBarroso bc09f2b
Fix codacy by removing f-string
GuillemBarroso cef3bed
Fix codacy adding shell=True when running subprocess
GuillemBarroso 14a624b
Fix codacy, change shell=False in subrocess run
GuillemBarroso 0bd5e45
Fix codacy, try to ignore subprocess run line
GuillemBarroso 560bd83
Fix codacy, ignore subprocess run
GuillemBarroso 7fac551
Resolve Codacy security warning for subprocess.run
PProfizi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GuillemBarroso What is that skipping for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
D400 indicates that the first line should end with a period, see doc.
@PProfizi, as we discussed, I will add the rule of ignoring D400 for the examples in the next PR, when I update the layout of the repo and I add the pre-commit.