Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/plot quadratic elements #910

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Apr 20, 2023

@PProfizi PProfizi added the bug Something isn't working label Apr 20, 2023
@PProfizi PProfizi self-assigned this Apr 20, 2023
@PProfizi PProfizi linked an issue Apr 20, 2023 that may be closed by this pull request
3 tasks
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #910 (ff4bc03) into master (3620fff) will decrease coverage by 1.74%.
The diff coverage is 88.05%.

@@            Coverage Diff             @@
##           master     #910      +/-   ##
==========================================
- Coverage   88.82%   87.09%   -1.74%     
==========================================
  Files          73       73              
  Lines        8297     8323      +26     
==========================================
- Hits         7370     7249     -121     
- Misses        927     1074     +147     

@PProfizi PProfizi marked this pull request as draft April 24, 2023 14:03
@PProfizi
Copy link
Contributor Author

#915 is used to merge the fixes on as_linear=True, without exposing as_linear argument in plotting methods.
The possibility to plot as_linear=False should only be merged when internal edges can be hidden, otherwise the plotting would still be wrong despite the underlying vtkUnstructuredGrid being right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plane183 Element - Cell type mismatch between mesh and grid
2 participants