Fix/plot mesh as linear #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…=False" This reverts commit dc29a27.
…hods. as_linear=False is not production-ready as internal edges of quadratic elements cannot be hidden
Codecov Report
@@ Coverage Diff @@
## master #915 +/- ##
==========================================
- Coverage 88.51% 86.64% -1.87%
==========================================
Files 73 73
Lines 8296 8327 +31
==========================================
- Hits 7343 7215 -128
- Misses 953 1112 +159 |
This reverts commit 8d3b230.
rafacanton
reviewed
Apr 27, 2023
| # insert_ind_quad8 += np.arange(insert_ind_quad8.size) | ||
| mask[insert_ind_quad8 + 5] = False | ||
| mask[insert_ind_quad8 + 6] = False | ||
| mask[insert_ind_quad8 + 7] = False |
There was a problem hiding this comment.
@PProfizi as part of the development in TFS for the mesh_to_pyvista, I handled all quadrratic eltypes, not only quads and shells. Thus, a hex20 will be plotted as a hex8, a wedge15 as a wedge6 and so on and so forth. This indeed makes the cells structure very light for solid meshes. Do you consider handling it in Python as well?
There was a problem hiding this comment.
@rafacanton you are right, I should add those. I did limit myself to fixing what was already dealt with.
There was a problem hiding this comment.
@PProfizi We can cover it in a different PR, if you think that's better
rafacanton
approved these changes
Apr 27, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
np.nanwhen semi-parabolic elements are present, even whenas_linear=Trueas_linear=TrueThe combination of these changes should make it possible to resolve #892
Should also solve #766