Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHORE: Temporary removal of docformatter hook #856

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

SMoraisAnsys
Copy link
Collaborator

As title says.

The reason for this change is related to a new major release of precommit where python_venv configuration can no longer be used. Since the docformatter is still using it ATM, we should temporarily comment this check.
Note that PyCQA/docformatter#287 fixes the problem and has been merged last week. We are just waiting for a new release.

svandenb-dev
svandenb-dev previously approved these changes Oct 17, 2024
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 17, 2024
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev merged commit 409ae16 into main Oct 17, 2024
29 checks passed
@svandenb-dev svandenb-dev deleted the chore/temporary-hook-removal branch October 17, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants