Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: New edb cfg example dcir #903

Merged
merged 13 commits into from
Nov 29, 2024
Merged

Conversation

hui-zhou-a
Copy link
Collaborator

No description provided.

@hui-zhou-a hui-zhou-a marked this pull request as draft November 20, 2024 12:16
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 20, 2024
@hui-zhou-a hui-zhou-a changed the title New edb cfg example dcir REFACTOR: New edb cfg example dcir Nov 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.58%. Comparing base (8313136) to head (a5b78fe).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #903   +/-   ##
=======================================
  Coverage   82.58%   82.58%           
=======================================
  Files         160      160           
  Lines       20988    20988           
=======================================
  Hits        17332    17332           
  Misses       3656     3656           

@hui-zhou-a hui-zhou-a marked this pull request as ready for review November 27, 2024 07:17
SMoraisAnsys
SMoraisAnsys previously approved these changes Nov 27, 2024
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left minor comments

examples/use_configuration/pcb_dc_ir.py Outdated Show resolved Hide resolved
examples/use_configuration/pcb_dc_ir.py Outdated Show resolved Hide resolved
hui-zhou-a and others added 3 commits November 27, 2024 12:15
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
SMoraisAnsys
SMoraisAnsys previously approved these changes Nov 28, 2024
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left a minor comment

examples/use_configuration/pcb_dc_ir.py Outdated Show resolved Hide resolved
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hui-zhou-a hui-zhou-a merged commit 34725f9 into main Nov 29, 2024
29 checks passed
@hui-zhou-a hui-zhou-a deleted the new-edb-cfg-example-dcir branch November 29, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants