REFACTOR: EDB configuration example for DCIR setup #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
hui-zhou-a
reviewed
Nov 28, 2024
There was a problem hiding this comment.
Please wait until #903 is merged. Then, merge main into this branch.
There are two more thing need to be done to make this example show up in documentation.
update doc/source/conf.py and exmaples/use_configuration/index.rst
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #917 +/- ##
=======================================
Coverage 82.67% 82.67%
=======================================
Files 160 160
Lines 21037 21037
=======================================
Hits 17392 17392
Misses 3645 3645 |
SMoraisAnsys
requested changes
Dec 1, 2024
There was a problem hiding this comment.
As @hui-zhou-a mentionned, you should also update how this file interacts with the configuration by modifying RST files and also conf.py if required you want to add a thumbnail manually.
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
SMoraisAnsys
reviewed
Dec 7, 2024
|
@hui-zhou-a Can you have a look at this PR now that #903 is merged ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.