Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tree) Fix parent checkbox state calculation (ant-design-blazor#1770) #1781

Merged
merged 1 commit into from
Jul 27, 2021
Merged

fix(module:tree) Fix parent checkbox state calculation (ant-design-blazor#1770) #1781

merged 1 commit into from
Jul 27, 2021

Conversation

lukblazewicz
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#1770

💡 Background and solution

Once the short-circuit optimization removed, the state of a parent node's checkbox is calculated correctly.

📝 Changelog

Language Changelog
🇺🇸 English Fix parent checkbox state calculation in a Tree
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Jul 27, 2021

@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #1781 (a29414d) into master (ae2ac61) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1781   +/-   ##
=======================================
  Coverage   20.77%   20.78%           
=======================================
  Files         478      478           
  Lines       30453    30452    -1     
=======================================
  Hits         6328     6328           
+ Misses      24125    24124    -1     
Impacted Files Coverage Δ
components/tree/TreeNode.razor.cs 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae2ac61...a29414d. Read the comment docs.

@ElderJames ElderJames merged commit fe8305e into ant-design-blazor:master Jul 27, 2021
anddrzejb pushed a commit to anddrzejb/ant-design-blazor that referenced this pull request Jul 29, 2021
ElderJames added a commit that referenced this pull request Aug 13, 2021
* refactor(module: table): use EnumSelect for table filter (#1777)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: tree): fix parent checkbox state calculation (#1781)

* fix(module: select): remove ValueName null check for non-datasource approach (#1785)

* fix(module: select): fix null value (#1786)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: select): MaxTagCount behaves properly for non-responsive scenarios (#1776)

* fix(module:select) MaxTagCount behaves property for non-responsive scenarios

docs: added XML comments
      fixed order in English docs
      redid Chinese docs (missing translations)

test: add scenario for MaxTagCount when non-responsive

* merge with changes coming from feature branch

* docs: example of MaxTagCount change

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* refactor(interop): reorganization into classes and typescript tests (#1791)

* fix(module:interop): reorganization into classes

* comments clean-up

* Add typescript test project

* fix: sync with pull request #1765: support drag

* github test action fix attempt

* tests: jsinterop test mock fix

* codecov added to ts tests

* add generated split js to gitignore

* fix: coverage github action

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: tree): one more fix to parent checkbox state calculation (#1781) (#1794)

* fix(module: modal): error when confirm TaskCompletionSource SetResult repeat (#1795)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): fix cascading table in column (#1732)

* fix(module: table): fix cascading tables

* Update Column.razor

* Update Column,razor

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* feat(module: tree): bring SearchExpression back (#1796)

* fix(module: RangePicker): ShowTime issues addressed (#1788)

* fix(module:rangePicker): year & month skip

* fix(module:rangePicker): extra space removed on 2nd picker

* fix(module:rangePicker): when ShowTime, click on OK moves to other picker

* fix(module:rangePicker): adjust year skip button

* fix(module:rangePicker): focus issue resolution

* fix(module:rangePicker): remove incorrect value from input

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: overlay): fix overlay position when container element has border (#1797)

* fix(module: overlay): use right positioning for bottom-right placement (#1799)

* fix(module: date-picker): update resource files (#1800)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: calendar): fix header select width (#1801)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: layout): fix OnBreakpoint and OnCollapse only when they was changed (#1815)

* fix(module: date-picker): fix ShowToday when ShowTime is true (#1819)

Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>

* doc: fix api markdown for autocomplete (#1808)

* Update index.en-US.md

* Update index.zh-CN.md

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): missing sorter model on first change (#1823)

* fix(module: upload): basic functionality restored (#1824)

* fix(module: table): use "or" filter condition for List type built-in filter (#1804)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: auto-complete): turn off the input `autocomplete` attribute (#1825)

* fix(module: date-picker): remain millisecond value when change the picker value (#1829)

* fix(module: input-number): `OnChange` cannot be triggered during keyboard input (#1830)

* fix(module: table): missing `showTime` of built-in datetime filter (#1827)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* changelog 0.9.1 (#1831)

Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
Co-authored-by: lukblazewicz <39852149+lukblazewicz@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>
Co-authored-by: heroboy <yangweiqin@gmail.com>
ElderJames added a commit that referenced this pull request Apr 23, 2022
* refactor(module: table): use EnumSelect for table filter (#1777)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: tree): fix parent checkbox state calculation (#1781)

* fix(module: select): remove ValueName null check for non-datasource approach (#1785)

* fix(module: select): fix null value (#1786)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: select): MaxTagCount behaves properly for non-responsive scenarios (#1776)

* fix(module:select) MaxTagCount behaves property for non-responsive scenarios

docs: added XML comments
      fixed order in English docs
      redid Chinese docs (missing translations)

test: add scenario for MaxTagCount when non-responsive

* merge with changes coming from feature branch

* docs: example of MaxTagCount change

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* refactor(interop): reorganization into classes and typescript tests (#1791)

* fix(module:interop): reorganization into classes

* comments clean-up

* Add typescript test project

* fix: sync with pull request #1765: support drag

* github test action fix attempt

* tests: jsinterop test mock fix

* codecov added to ts tests

* add generated split js to gitignore

* fix: coverage github action

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: tree): one more fix to parent checkbox state calculation (#1781) (#1794)

* fix(module: modal): error when confirm TaskCompletionSource SetResult repeat (#1795)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): fix cascading table in column (#1732)

* fix(module: table): fix cascading tables

* Update Column.razor

* Update Column,razor

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* feat(module: tree): bring SearchExpression back (#1796)

* fix(module: RangePicker): ShowTime issues addressed (#1788)

* fix(module:rangePicker): year & month skip

* fix(module:rangePicker): extra space removed on 2nd picker

* fix(module:rangePicker): when ShowTime, click on OK moves to other picker

* fix(module:rangePicker): adjust year skip button

* fix(module:rangePicker): focus issue resolution

* fix(module:rangePicker): remove incorrect value from input

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: overlay): fix overlay position when container element has border (#1797)

* fix(module: overlay): use right positioning for bottom-right placement (#1799)

* fix(module: date-picker): update resource files (#1800)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: calendar): fix header select width (#1801)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: layout): fix OnBreakpoint and OnCollapse only when they was changed (#1815)

* fix(module: date-picker): fix ShowToday when ShowTime is true (#1819)

Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>

* doc: fix api markdown for autocomplete (#1808)

* Update index.en-US.md

* Update index.zh-CN.md

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): missing sorter model on first change (#1823)

* fix(module: upload): basic functionality restored (#1824)

* fix(module: table): use "or" filter condition for List type built-in filter (#1804)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: auto-complete): turn off the input `autocomplete` attribute (#1825)

* fix(module: date-picker): remain millisecond value when change the picker value (#1829)

* fix(module: input-number): `OnChange` cannot be triggered during keyboard input (#1830)

* fix(module: table): missing `showTime` of built-in datetime filter (#1827)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* changelog 0.9.1 (#1831)

Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
Co-authored-by: lukblazewicz <39852149+lukblazewicz@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>
Co-authored-by: heroboy <yangweiqin@gmail.com>
ElderJames added a commit that referenced this pull request Apr 30, 2022
* refactor(module: table): use EnumSelect for table filter (#1777)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: tree): fix parent checkbox state calculation (#1781)

* fix(module: select): remove ValueName null check for non-datasource approach (#1785)

* fix(module: select): fix null value (#1786)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: select): MaxTagCount behaves properly for non-responsive scenarios (#1776)

* fix(module:select) MaxTagCount behaves property for non-responsive scenarios

docs: added XML comments
      fixed order in English docs
      redid Chinese docs (missing translations)

test: add scenario for MaxTagCount when non-responsive

* merge with changes coming from feature branch

* docs: example of MaxTagCount change

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* refactor(interop): reorganization into classes and typescript tests (#1791)

* fix(module:interop): reorganization into classes

* comments clean-up

* Add typescript test project

* fix: sync with pull request #1765: support drag

* github test action fix attempt

* tests: jsinterop test mock fix

* codecov added to ts tests

* add generated split js to gitignore

* fix: coverage github action

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: tree): one more fix to parent checkbox state calculation (#1781) (#1794)

* fix(module: modal): error when confirm TaskCompletionSource SetResult repeat (#1795)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): fix cascading table in column (#1732)

* fix(module: table): fix cascading tables

* Update Column.razor

* Update Column,razor

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* feat(module: tree): bring SearchExpression back (#1796)

* fix(module: RangePicker): ShowTime issues addressed (#1788)

* fix(module:rangePicker): year & month skip

* fix(module:rangePicker): extra space removed on 2nd picker

* fix(module:rangePicker): when ShowTime, click on OK moves to other picker

* fix(module:rangePicker): adjust year skip button

* fix(module:rangePicker): focus issue resolution

* fix(module:rangePicker): remove incorrect value from input

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: overlay): fix overlay position when container element has border (#1797)

* fix(module: overlay): use right positioning for bottom-right placement (#1799)

* fix(module: date-picker): update resource files (#1800)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: calendar): fix header select width (#1801)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: layout): fix OnBreakpoint and OnCollapse only when they was changed (#1815)

* fix(module: date-picker): fix ShowToday when ShowTime is true (#1819)

Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>

* doc: fix api markdown for autocomplete (#1808)

* Update index.en-US.md

* Update index.zh-CN.md

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): missing sorter model on first change (#1823)

* fix(module: upload): basic functionality restored (#1824)

* fix(module: table): use "or" filter condition for List type built-in filter (#1804)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: auto-complete): turn off the input `autocomplete` attribute (#1825)

* fix(module: date-picker): remain millisecond value when change the picker value (#1829)

* fix(module: input-number): `OnChange` cannot be triggered during keyboard input (#1830)

* fix(module: table): missing `showTime` of built-in datetime filter (#1827)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* changelog 0.9.1 (#1831)

Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
Co-authored-by: lukblazewicz <39852149+lukblazewicz@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>
Co-authored-by: heroboy <yangweiqin@gmail.com>
ElderJames added a commit that referenced this pull request Sep 6, 2022
* refactor(module: table): use EnumSelect for table filter (#1777)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: tree): fix parent checkbox state calculation (#1781)

* fix(module: select): remove ValueName null check for non-datasource approach (#1785)

* fix(module: select): fix null value (#1786)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: select): MaxTagCount behaves properly for non-responsive scenarios (#1776)

* fix(module:select) MaxTagCount behaves property for non-responsive scenarios

docs: added XML comments
      fixed order in English docs
      redid Chinese docs (missing translations)

test: add scenario for MaxTagCount when non-responsive

* merge with changes coming from feature branch

* docs: example of MaxTagCount change

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* refactor(interop): reorganization into classes and typescript tests (#1791)

* fix(module:interop): reorganization into classes

* comments clean-up

* Add typescript test project

* fix: sync with pull request #1765: support drag

* github test action fix attempt

* tests: jsinterop test mock fix

* codecov added to ts tests

* add generated split js to gitignore

* fix: coverage github action

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: tree): one more fix to parent checkbox state calculation (#1781) (#1794)

* fix(module: modal): error when confirm TaskCompletionSource SetResult repeat (#1795)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): fix cascading table in column (#1732)

* fix(module: table): fix cascading tables

* Update Column.razor

* Update Column,razor

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* feat(module: tree): bring SearchExpression back (#1796)

* fix(module: RangePicker): ShowTime issues addressed (#1788)

* fix(module:rangePicker): year & month skip

* fix(module:rangePicker): extra space removed on 2nd picker

* fix(module:rangePicker): when ShowTime, click on OK moves to other picker

* fix(module:rangePicker): adjust year skip button

* fix(module:rangePicker): focus issue resolution

* fix(module:rangePicker): remove incorrect value from input

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: overlay): fix overlay position when container element has border (#1797)

* fix(module: overlay): use right positioning for bottom-right placement (#1799)

* fix(module: date-picker): update resource files (#1800)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: calendar): fix header select width (#1801)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: layout): fix OnBreakpoint and OnCollapse only when they was changed (#1815)

* fix(module: date-picker): fix ShowToday when ShowTime is true (#1819)

Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>

* doc: fix api markdown for autocomplete (#1808)

* Update index.en-US.md

* Update index.zh-CN.md

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): missing sorter model on first change (#1823)

* fix(module: upload): basic functionality restored (#1824)

* fix(module: table): use "or" filter condition for List type built-in filter (#1804)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: auto-complete): turn off the input `autocomplete` attribute (#1825)

* fix(module: date-picker): remain millisecond value when change the picker value (#1829)

* fix(module: input-number): `OnChange` cannot be triggered during keyboard input (#1830)

* fix(module: table): missing `showTime` of built-in datetime filter (#1827)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* changelog 0.9.1 (#1831)

Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
Co-authored-by: lukblazewicz <39852149+lukblazewicz@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>
Co-authored-by: heroboy <yangweiqin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tree] Incorrect checkbox state on the TreeNode due to an optimization inside UpdateCheckState()
2 participants