Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: input-number): OnChange cannot be triggered during keyboard input #1830

Merged
merged 2 commits into from
Aug 9, 2021

Conversation

ElderJames
Copy link
Member

…oard input

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #1734

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@ElderJames ElderJames changed the title fix(module: input-number): OnChange cannot be triggered during keyb… fix(module: input-number): OnChange cannot be triggered during keyboard input Aug 9, 2021
@github-actions
Copy link

github-actions bot commented Aug 9, 2021

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #1830 (b127777) into master (5a0ad4e) will increase coverage by 23.50%.
The diff coverage is 25.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1830       +/-   ##
===========================================
+ Coverage    0.00%   23.50%   +23.50%     
===========================================
  Files         478      495       +17     
  Lines       31159    23216     -7943     
  Branches        0      121      +121     
===========================================
+ Hits            0     5456     +5456     
+ Misses      31159    17757    -13402     
- Partials        0        3        +3     
Impacted Files Coverage Δ
components/input-number/InputNumber.razor.cs 56.77% <25.00%> (+56.77%) ⬆️
components/card/Card.razor 0.00% <0.00%> (ø)
components/form/Form.razor 0.00% <0.00%> (ø)
components/rate/Rate.razor 0.00% <0.00%> (ø)
components/spin/Spin.razor 0.00% <0.00%> (ø)
components/tree/Tree.razor 0.00% <0.00%> (ø)
components/menu/MenuLink.cs 0.00% <0.00%> (ø)
components/menu/MenuMode.cs 0.00% <0.00%> (ø)
components/steps/Step.razor 0.00% <0.00%> (ø)
components/affix/Affix.razor 0.00% <0.00%> (ø)
... and 438 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a0ad4e...b127777. Read the comment docs.

@ElderJames ElderJames merged commit f6dbe12 into master Aug 9, 2021
@ElderJames ElderJames deleted the fix/input-number-keyboard-change branch August 9, 2021 14:50
ElderJames added a commit that referenced this pull request Aug 13, 2021
* refactor(module: table): use EnumSelect for table filter (#1777)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: tree): fix parent checkbox state calculation (#1781)

* fix(module: select): remove ValueName null check for non-datasource approach (#1785)

* fix(module: select): fix null value (#1786)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: select): MaxTagCount behaves properly for non-responsive scenarios (#1776)

* fix(module:select) MaxTagCount behaves property for non-responsive scenarios

docs: added XML comments
      fixed order in English docs
      redid Chinese docs (missing translations)

test: add scenario for MaxTagCount when non-responsive

* merge with changes coming from feature branch

* docs: example of MaxTagCount change

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* refactor(interop): reorganization into classes and typescript tests (#1791)

* fix(module:interop): reorganization into classes

* comments clean-up

* Add typescript test project

* fix: sync with pull request #1765: support drag

* github test action fix attempt

* tests: jsinterop test mock fix

* codecov added to ts tests

* add generated split js to gitignore

* fix: coverage github action

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: tree): one more fix to parent checkbox state calculation (#1781) (#1794)

* fix(module: modal): error when confirm TaskCompletionSource SetResult repeat (#1795)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): fix cascading table in column (#1732)

* fix(module: table): fix cascading tables

* Update Column.razor

* Update Column,razor

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* feat(module: tree): bring SearchExpression back (#1796)

* fix(module: RangePicker): ShowTime issues addressed (#1788)

* fix(module:rangePicker): year & month skip

* fix(module:rangePicker): extra space removed on 2nd picker

* fix(module:rangePicker): when ShowTime, click on OK moves to other picker

* fix(module:rangePicker): adjust year skip button

* fix(module:rangePicker): focus issue resolution

* fix(module:rangePicker): remove incorrect value from input

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: overlay): fix overlay position when container element has border (#1797)

* fix(module: overlay): use right positioning for bottom-right placement (#1799)

* fix(module: date-picker): update resource files (#1800)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: calendar): fix header select width (#1801)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: layout): fix OnBreakpoint and OnCollapse only when they was changed (#1815)

* fix(module: date-picker): fix ShowToday when ShowTime is true (#1819)

Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>

* doc: fix api markdown for autocomplete (#1808)

* Update index.en-US.md

* Update index.zh-CN.md

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): missing sorter model on first change (#1823)

* fix(module: upload): basic functionality restored (#1824)

* fix(module: table): use "or" filter condition for List type built-in filter (#1804)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: auto-complete): turn off the input `autocomplete` attribute (#1825)

* fix(module: date-picker): remain millisecond value when change the picker value (#1829)

* fix(module: input-number): `OnChange` cannot be triggered during keyboard input (#1830)

* fix(module: table): missing `showTime` of built-in datetime filter (#1827)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* changelog 0.9.1 (#1831)

Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
Co-authored-by: lukblazewicz <39852149+lukblazewicz@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>
Co-authored-by: heroboy <yangweiqin@gmail.com>
ElderJames added a commit that referenced this pull request Apr 23, 2022
ElderJames added a commit that referenced this pull request Apr 23, 2022
* refactor(module: table): use EnumSelect for table filter (#1777)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: tree): fix parent checkbox state calculation (#1781)

* fix(module: select): remove ValueName null check for non-datasource approach (#1785)

* fix(module: select): fix null value (#1786)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: select): MaxTagCount behaves properly for non-responsive scenarios (#1776)

* fix(module:select) MaxTagCount behaves property for non-responsive scenarios

docs: added XML comments
      fixed order in English docs
      redid Chinese docs (missing translations)

test: add scenario for MaxTagCount when non-responsive

* merge with changes coming from feature branch

* docs: example of MaxTagCount change

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* refactor(interop): reorganization into classes and typescript tests (#1791)

* fix(module:interop): reorganization into classes

* comments clean-up

* Add typescript test project

* fix: sync with pull request #1765: support drag

* github test action fix attempt

* tests: jsinterop test mock fix

* codecov added to ts tests

* add generated split js to gitignore

* fix: coverage github action

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: tree): one more fix to parent checkbox state calculation (#1781) (#1794)

* fix(module: modal): error when confirm TaskCompletionSource SetResult repeat (#1795)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): fix cascading table in column (#1732)

* fix(module: table): fix cascading tables

* Update Column.razor

* Update Column,razor

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* feat(module: tree): bring SearchExpression back (#1796)

* fix(module: RangePicker): ShowTime issues addressed (#1788)

* fix(module:rangePicker): year & month skip

* fix(module:rangePicker): extra space removed on 2nd picker

* fix(module:rangePicker): when ShowTime, click on OK moves to other picker

* fix(module:rangePicker): adjust year skip button

* fix(module:rangePicker): focus issue resolution

* fix(module:rangePicker): remove incorrect value from input

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: overlay): fix overlay position when container element has border (#1797)

* fix(module: overlay): use right positioning for bottom-right placement (#1799)

* fix(module: date-picker): update resource files (#1800)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: calendar): fix header select width (#1801)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: layout): fix OnBreakpoint and OnCollapse only when they was changed (#1815)

* fix(module: date-picker): fix ShowToday when ShowTime is true (#1819)

Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>

* doc: fix api markdown for autocomplete (#1808)

* Update index.en-US.md

* Update index.zh-CN.md

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): missing sorter model on first change (#1823)

* fix(module: upload): basic functionality restored (#1824)

* fix(module: table): use "or" filter condition for List type built-in filter (#1804)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: auto-complete): turn off the input `autocomplete` attribute (#1825)

* fix(module: date-picker): remain millisecond value when change the picker value (#1829)

* fix(module: input-number): `OnChange` cannot be triggered during keyboard input (#1830)

* fix(module: table): missing `showTime` of built-in datetime filter (#1827)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* changelog 0.9.1 (#1831)

Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
Co-authored-by: lukblazewicz <39852149+lukblazewicz@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>
Co-authored-by: heroboy <yangweiqin@gmail.com>
ElderJames added a commit that referenced this pull request Apr 30, 2022
ElderJames added a commit that referenced this pull request Apr 30, 2022
* refactor(module: table): use EnumSelect for table filter (#1777)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: tree): fix parent checkbox state calculation (#1781)

* fix(module: select): remove ValueName null check for non-datasource approach (#1785)

* fix(module: select): fix null value (#1786)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: select): MaxTagCount behaves properly for non-responsive scenarios (#1776)

* fix(module:select) MaxTagCount behaves property for non-responsive scenarios

docs: added XML comments
      fixed order in English docs
      redid Chinese docs (missing translations)

test: add scenario for MaxTagCount when non-responsive

* merge with changes coming from feature branch

* docs: example of MaxTagCount change

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* refactor(interop): reorganization into classes and typescript tests (#1791)

* fix(module:interop): reorganization into classes

* comments clean-up

* Add typescript test project

* fix: sync with pull request #1765: support drag

* github test action fix attempt

* tests: jsinterop test mock fix

* codecov added to ts tests

* add generated split js to gitignore

* fix: coverage github action

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: tree): one more fix to parent checkbox state calculation (#1781) (#1794)

* fix(module: modal): error when confirm TaskCompletionSource SetResult repeat (#1795)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): fix cascading table in column (#1732)

* fix(module: table): fix cascading tables

* Update Column.razor

* Update Column,razor

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* feat(module: tree): bring SearchExpression back (#1796)

* fix(module: RangePicker): ShowTime issues addressed (#1788)

* fix(module:rangePicker): year & month skip

* fix(module:rangePicker): extra space removed on 2nd picker

* fix(module:rangePicker): when ShowTime, click on OK moves to other picker

* fix(module:rangePicker): adjust year skip button

* fix(module:rangePicker): focus issue resolution

* fix(module:rangePicker): remove incorrect value from input

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: overlay): fix overlay position when container element has border (#1797)

* fix(module: overlay): use right positioning for bottom-right placement (#1799)

* fix(module: date-picker): update resource files (#1800)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: calendar): fix header select width (#1801)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: layout): fix OnBreakpoint and OnCollapse only when they was changed (#1815)

* fix(module: date-picker): fix ShowToday when ShowTime is true (#1819)

Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>

* doc: fix api markdown for autocomplete (#1808)

* Update index.en-US.md

* Update index.zh-CN.md

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): missing sorter model on first change (#1823)

* fix(module: upload): basic functionality restored (#1824)

* fix(module: table): use "or" filter condition for List type built-in filter (#1804)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: auto-complete): turn off the input `autocomplete` attribute (#1825)

* fix(module: date-picker): remain millisecond value when change the picker value (#1829)

* fix(module: input-number): `OnChange` cannot be triggered during keyboard input (#1830)

* fix(module: table): missing `showTime` of built-in datetime filter (#1827)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* changelog 0.9.1 (#1831)

Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
Co-authored-by: lukblazewicz <39852149+lukblazewicz@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>
Co-authored-by: heroboy <yangweiqin@gmail.com>
ElderJames added a commit that referenced this pull request Sep 6, 2022
ElderJames added a commit that referenced this pull request Sep 6, 2022
* refactor(module: table): use EnumSelect for table filter (#1777)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: tree): fix parent checkbox state calculation (#1781)

* fix(module: select): remove ValueName null check for non-datasource approach (#1785)

* fix(module: select): fix null value (#1786)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: select): MaxTagCount behaves properly for non-responsive scenarios (#1776)

* fix(module:select) MaxTagCount behaves property for non-responsive scenarios

docs: added XML comments
      fixed order in English docs
      redid Chinese docs (missing translations)

test: add scenario for MaxTagCount when non-responsive

* merge with changes coming from feature branch

* docs: example of MaxTagCount change

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* refactor(interop): reorganization into classes and typescript tests (#1791)

* fix(module:interop): reorganization into classes

* comments clean-up

* Add typescript test project

* fix: sync with pull request #1765: support drag

* github test action fix attempt

* tests: jsinterop test mock fix

* codecov added to ts tests

* add generated split js to gitignore

* fix: coverage github action

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: tree): one more fix to parent checkbox state calculation (#1781) (#1794)

* fix(module: modal): error when confirm TaskCompletionSource SetResult repeat (#1795)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): fix cascading table in column (#1732)

* fix(module: table): fix cascading tables

* Update Column.razor

* Update Column,razor

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* feat(module: tree): bring SearchExpression back (#1796)

* fix(module: RangePicker): ShowTime issues addressed (#1788)

* fix(module:rangePicker): year & month skip

* fix(module:rangePicker): extra space removed on 2nd picker

* fix(module:rangePicker): when ShowTime, click on OK moves to other picker

* fix(module:rangePicker): adjust year skip button

* fix(module:rangePicker): focus issue resolution

* fix(module:rangePicker): remove incorrect value from input

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: overlay): fix overlay position when container element has border (#1797)

* fix(module: overlay): use right positioning for bottom-right placement (#1799)

* fix(module: date-picker): update resource files (#1800)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: calendar): fix header select width (#1801)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: layout): fix OnBreakpoint and OnCollapse only when they was changed (#1815)

* fix(module: date-picker): fix ShowToday when ShowTime is true (#1819)

Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>

* doc: fix api markdown for autocomplete (#1808)

* Update index.en-US.md

* Update index.zh-CN.md

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): missing sorter model on first change (#1823)

* fix(module: upload): basic functionality restored (#1824)

* fix(module: table): use "or" filter condition for List type built-in filter (#1804)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: auto-complete): turn off the input `autocomplete` attribute (#1825)

* fix(module: date-picker): remain millisecond value when change the picker value (#1829)

* fix(module: input-number): `OnChange` cannot be triggered during keyboard input (#1830)

* fix(module: table): missing `showTime` of built-in datetime filter (#1827)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* changelog 0.9.1 (#1831)

Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
Co-authored-by: lukblazewicz <39852149+lukblazewicz@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>
Co-authored-by: heroboy <yangweiqin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant