Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade client-go to v0.24 when it is available #3584

Closed
antoninbas opened this issue Apr 5, 2022 · 0 comments · Fixed by #3742
Closed

Upgrade client-go to v0.24 when it is available #3584

antoninbas opened this issue Apr 5, 2022 · 0 comments · Fixed by #3742
Assignees
@antoninbas
Labels
area/dependency Issues or PRs related to dependency changes. kind/task Categorizes issue or PR as related to a routine task that needs to be performed

Comments

@antoninbas
Copy link
Contributor

For #3497 and #3540
@antoninbas antoninbas added kind/task Categorizes issue or PR as related to a routine task that needs to be performed area/dependency Issues or PRs related to dependency changes. labels Apr 5, 2022
@antoninbas antoninbas self-assigned this May 7, 2022
antoninbas added a commit to antoninbas/antrea that referenced this issue May 7, 2022
@antoninbas
Upgrading K8s libraries to v0.24
e0d646b 
Some notable changes since v0.21:
* some apiserver library functions have a new signature and now take a
  context.Context instead of a stopCh
* TopologyKeys was removed from ServiceSpec (this required a small
  cleanup in the third-party proxy code)
* SelfLink field for K8s metadata (ListMeta / ObjectMeta) was deprecated
* k8s.io/apimachinery/util/clock was deprecated and replaced with
  k8s.io/utils/clock
* there was a small change in k8s.io/kubectl/pkg/proxy, which we use to
  implement "antctl proxy"

Fixes antrea-io#3118
Fixes antrea-io#3497
Fixes antrea-io#3584

Signed-off-by: Antonin Bas <abas@vmware.com>
@antoninbas antoninbas mentioned this issue May 7, 2022
Merged
antoninbas added a commit to antoninbas/antrea that referenced this issue May 7, 2022
@antoninbas
Upgrade K8s libraries to v0.24
6daa694 
Some notable changes since v0.21:
* some apiserver library functions have a new signature and now take a
  context.Context instead of a stopCh
* TopologyKeys was removed from ServiceSpec (this required a small
  cleanup in the third-party proxy code)
* SelfLink field for K8s metadata (ListMeta / ObjectMeta) was deprecated
* k8s.io/apimachinery/util/clock was deprecated and replaced with
  k8s.io/utils/clock
* there was a small change in k8s.io/kubectl/pkg/proxy, which we use to
  implement "antctl proxy"

Fixes antrea-io#3118
Fixes antrea-io#3497
Fixes antrea-io#3584

Signed-off-by: Antonin Bas <abas@vmware.com>
antoninbas added a commit to antoninbas/antrea that referenced this issue May 13, 2022
@antoninbas
Upgrade K8s libraries to v0.24
0b71518 
Some notable changes since v0.21:
* some apiserver library functions have a new signature and now take a
  context.Context instead of a stopCh
* TopologyKeys was removed from ServiceSpec (this required a small
  cleanup in the third-party proxy code)
* SelfLink field for K8s metadata (ListMeta / ObjectMeta) was deprecated
* k8s.io/apimachinery/util/clock was deprecated and replaced with
  k8s.io/utils/clock
* there was a small change in k8s.io/kubectl/pkg/proxy, which we use to
  implement "antctl proxy"

Fixes antrea-io#3118
Fixes antrea-io#3497
Fixes antrea-io#3584

Signed-off-by: Antonin Bas <abas@vmware.com>
antoninbas added a commit to antoninbas/antrea that referenced this issue May 16, 2022
@antoninbas
Upgrade K8s libraries to v0.24
f8a705a 
Some notable changes since v0.21:
* some apiserver library functions have a new signature and now take a
  context.Context instead of a stopCh
* TopologyKeys was removed from ServiceSpec (this required a small
  cleanup in the third-party proxy code)
* SelfLink field for K8s metadata (ListMeta / ObjectMeta) was deprecated
* k8s.io/apimachinery/util/clock was deprecated and replaced with
  k8s.io/utils/clock
* there was a small change in k8s.io/kubectl/pkg/proxy, which we use to
  implement "antctl proxy"

Fixes antrea-io#3118
Fixes antrea-io#3497
Fixes antrea-io#3584

Signed-off-by: Antonin Bas <abas@vmware.com>
antoninbas added a commit to antoninbas/antrea that referenced this issue May 17, 2022
@antoninbas
Upgrade K8s libraries to v0.24
0e2204d 
Some notable changes since v0.21:
* some apiserver library functions have a new signature and now take a
  context.Context instead of a stopCh
* TopologyKeys was removed from ServiceSpec (this required a small
  cleanup in the third-party proxy code)
* SelfLink field for K8s metadata (ListMeta / ObjectMeta) was deprecated
* k8s.io/apimachinery/util/clock was deprecated and replaced with
  k8s.io/utils/clock
* there was a small change in k8s.io/kubectl/pkg/proxy, which we use to
  implement "antctl proxy"
* additional metrics were added to the apiserver, so we needed to
  regenerate the Prometheus metrics doc

Fixes antrea-io#3118
Fixes antrea-io#3497
Fixes antrea-io#3584

Signed-off-by: Antonin Bas <abas@vmware.com>
antoninbas added a commit that referenced this issue May 17, 2022
@antoninbas
Upgrade K8s libraries to v0.24 (#3742)
3a51abe 
* Upgrade K8s libraries to v0.24

Some notable changes since v0.21:
* some apiserver library functions have a new signature and now take a
  context.Context instead of a stopCh
* TopologyKeys was removed from ServiceSpec (this required a small
  cleanup in the third-party proxy code)
* SelfLink field for K8s metadata (ListMeta / ObjectMeta) was deprecated
* k8s.io/apimachinery/util/clock was deprecated and replaced with
  k8s.io/utils/clock
* there was a small change in k8s.io/kubectl/pkg/proxy, which we use to
  implement "antctl proxy"
* additional metrics were added to the apiserver, so we needed to
  regenerate the Prometheus metrics doc

Fixes #3118
Fixes #3497
Fixes #3584

Signed-off-by: Antonin Bas <abas@vmware.com>

* Fix logging after upgrading to K8s v1.24

klog flags are no longer added automatically to the command-line when
running the InitLogs() function (from k8s.io/component-base/logs). The
AddFlags() function must be called first, with the InitLogs() function
being called after flags have been parsed.

Note that K8s has deprecated klog flags as part of
https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/2845-deprecate-klog-specific-flags-in-k8s-components.
When these flags are used, a deprecation warning is displayed. We need
to revisit how we do logging for Antrea components.

Signed-off-by: Antonin Bas <abas@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antoninbas antoninbas

Labels
area/dependency Issues or PRs related to dependency changes. kind/task Categorizes issue or PR as related to a routine task that needs to be performed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade K8s libraries to v0.24 antoninbas/antrea
1 participant
@antoninbas