Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out a stable path for SSL installation in install-ovs.ps1 #5479

Closed
jayunit100 opened this issue Sep 12, 2023 · 0 comments · Fixed by #5510
Closed

Figure out a stable path for SSL installation in install-ovs.ps1 #5479

jayunit100 opened this issue Sep 12, 2023 · 0 comments · Fixed by #5510
Labels
area/OS/windows Issues or PRs related to the Windows operating system. kind/bug Categorizes issue or PR as related to a bug. reported-by/end-user Issues reported by end users.

Comments

@jayunit100
Copy link
Contributor

jayunit100 commented Sep 12, 2023 •
edited
Loading

Describe the bug

Hi Antrea !

So, our SSL story https://github.com/antrea-io/antrea/blob/main/hack/windows/Install-OVS.ps1#L217 Appears to give some folks problems, but not other folks... I suppose its based on where they're pulling things down from and wether they trust sites like fulgan.com.

The hardcoded fulgan.com URL is likely the root cause of all this - we need to find a way to more gracefully and intentionally configure SSL and heavily document it so there is no ambiguity or magic behavior in the future.

This has hit us in the past (kubernetes-sigs/sig-windows-dev-tools#198) and there was some work done to make it better, but I don't fully understand what the end result should be... the TLDR is that,

requirements

  • we just need an intentional, configurable SSL and OVS installation process for windows
  • that is easy for people to understand and/or troubleshoot,
  • and which may use URLs from the internet for defaults, but all the while allows for alt. URLs in case those are unavailable.

To Reproduce

Not quite sure how to reproduce this, but we've seen it from time to time in the past

Expected

Actual behavior

Its not clear what to do in cases where

Download SSL files failed, URL: https://indy.fulgan.com/SSL/openssl-1.0.2u-x64_86-win64.zip

happens. We need a workaround or fallback url for people who cannot access, or do not trust, this HTTPS endpoint, that can be plumbed in or just automatically works in the install-ovs.ps1 scripts
@jayunit100 jayunit100 added the kind/bug Categorizes issue or PR as related to a bug. label Sep 12, 2023
@XinShuYang XinShuYang added the area/OS/windows Issues or PRs related to the Windows operating system. label Sep 13, 2023
XinShuYang added a commit to XinShuYang/antrea that referenced this issue Sep 20, 2023
@XinShuYang
Fix Bugs and Introduce Enhancements in Install-OVS.ps1
a732f8b 
* Fix the bug to prevent downloading the SSL library if files exist in the host path.
* Add a parameter to support installing local SSL library.
* Update the SSL download URL to the GitHub link.

Fixes antrea-io#5479

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
@XinShuYang XinShuYang mentioned this issue Sep 20, 2023
Merged
tnqn pushed a commit that referenced this issue Sep 20, 2023
@XinShuYang
Fix Bugs and Introduce Enhancements in Install-OVS.ps1 (#5510)
de7a4f5 
* Fix the bug to prevent downloading the SSL library if files exist in the host path.
* Add a parameter to support installing local SSL library.
* Update the SSL download URL to the GitHub link.

Fixes #5479

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
XinShuYang added a commit to XinShuYang/antrea that referenced this issue Oct 10, 2023
@XinShuYang
Fix Bugs and Introduce Enhancements in Install-OVS.ps1
0ea85ad 
* Fix the bug to prevent downloading the SSL library if files exist in the host path.
* Add a parameter to support installing local SSL library.
* Update the SSL download URL to the GitHub link.

Fixes antrea-io#5479

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
XinShuYang added a commit to XinShuYang/antrea that referenced this issue Oct 10, 2023
@XinShuYang
Fix Bugs and Introduce Enhancements in Install-OVS.ps1
7bef9ab 
* Fix the bug to prevent downloading the SSL library if files exist in the host path.
* Add a parameter to support installing local SSL library.
* Update the SSL download URL to the GitHub link.

Fixes antrea-io#5479

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
XinShuYang added a commit to XinShuYang/antrea that referenced this issue Oct 10, 2023
@XinShuYang
Fix Bugs and Introduce Enhancements in Install-OVS.ps1
05d6e7f 
* Fix the bug to prevent downloading the SSL library if files exist in the host path.
* Add a parameter to support installing local SSL library.
* Update the SSL download URL to the GitHub link.

Fixes antrea-io#5479

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
tnqn pushed a commit that referenced this issue Oct 16, 2023
@XinShuYang
Fix Bugs and Introduce Enhancements in Install-OVS.ps1 (#5563)
1c61d68 
* Fix the bug to prevent downloading the SSL library if files exist in the host path.
* Add a parameter to support installing local SSL library.
* Update the SSL download URL to the GitHub link.

Fixes #5479

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
tnqn pushed a commit that referenced this issue Oct 16, 2023
@XinShuYang
Fix Bugs and Introduce Enhancements in Install-OVS.ps1 (#5562)
ff33739 
* Fix the bug to prevent downloading the SSL library if files exist in the host path.
* Add a parameter to support installing local SSL library.
* Update the SSL download URL to the GitHub link.

Fixes #5479

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
tnqn pushed a commit that referenced this issue Oct 16, 2023
@XinShuYang
Fix Bugs and Introduce Enhancements in Install-OVS.ps1 (#5561)
870fd65 
* Fix the bug to prevent downloading the SSL library if files exist in the host path.
* Add a parameter to support installing local SSL library.
* Update the SSL download URL to the GitHub link.

Fixes #5479

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
@XinShuYang XinShuYang mentioned this issue Oct 17, 2023
Closed
@tnqn tnqn added the reported-by/end-user Issues reported by end users. label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/OS/windows Issues or PRs related to the Windows operating system. kind/bug Categorizes issue or PR as related to a bug. reported-by/end-user Issues reported by end users.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Bugs and Introduce Enhancements in Install-OVS.ps1 XinShuYang/antrea
3 participants
@jayunit100 @tnqn @XinShuYang