Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bugs and Introduce Enhancements in Install-OVS.ps1 #5510

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Fix Bugs and Introduce Enhancements in Install-OVS.ps1 #5510

merged 1 commit into from
Sep 20, 2023

Conversation

XinShuYang
Copy link
Contributor

  • Fix the bug to prevent downloading the SSL library if files exist in the host path.
  • Add a parameter to support installing local SSL library.
  • Update the SSL download URL to the GitHub link.

Fixes #5479

@XinShuYang
Fix Bugs and Introduce Enhancements in Install-OVS.ps1
a732f8b 
* Fix the bug to prevent downloading the SSL library if files exist in the host path.
* Add a parameter to support installing local SSL library.
* Update the SSL download URL to the GitHub link.

Fixes antrea-io#5479

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
@XinShuYang XinShuYang requested a review from wenyingd September 20, 2023 09:13
@tnqn tnqn added the action/release-note Indicates a PR that should be included in release notes. label Sep 20, 2023
tnqn
tnqn approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn
Copy link
Member

tnqn commented Sep 20, 2023

/skip-all

@tnqn tnqn merged commit de7a4f5 into antrea-io:main Sep 20, 2023
44 checks passed
This was referenced Oct 10, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnqn tnqn tnqn approved these changes

@wenyingd wenyingd wenyingd approved these changes

Assignees
No one assigned
Labels
action/release-note Indicates a PR that should be included in release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Figure out a stable path for SSL installation in install-ovs.ps1
3 participants
@XinShuYang @tnqn @wenyingd