Fix controller issue in handling empty pod labels for labelidentity #5404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dyanngg
added
kind/bug
GraysonWu
reviewed
Aug 17, 2023
luolanzone
previously approved these changes
Aug 18, 2023
Dyanngg
force-pushed
the
fix-empty-label-crash
branch
from
416199d to
e9edd06
Compare
tnqn
reviewed
Aug 18, 2023
Comment on lines
36
to
37
| // As defined in https://github.com/kubernetes/apimachinery/blob/3e2600dc79feea6cdc8a9224bc8a6a7fcfee1466/pkg/labels/labels.go#L90 | ||
| emptyLabels = "<none>" |
There was a problem hiding this comment.
Should we call labels.Set(...).String() instead of labels.FormatLabels(...) to return a clearer format? I think the latter is only used when printing the labels in kubectl for human readaibility.
There was a problem hiding this comment.
Yeah I think we could do that. Updated
When a Pod is created without any labels at all, its labelidentity will include "pod:<none>" as defined by FormatLabels in apimachinery. This case is not handled correctly by the label group index and can cause the controller to crash. Signed-off-by: Dyanngg <dingyang@vmware.com>
Dyanngg
force-pushed
the
fix-empty-label-crash
branch
from
e9edd06 to
c89b01f
Compare
|
/test-multicluster-e2e |
|
/test-multicluster-e2e |
2 similar comments
|
/test-multicluster-e2e |
|
/test-multicluster-e2e |
|
/skip-all |
tnqn
added
the
action/release-note
|
@Dyanngg please backport it to applicable releases. |
This was referenced Aug 22, 2023
Dyanngg
added a commit
to Dyanngg/antrea
that referenced
this pull request
Aug 28, 2023
…fter upgrade This is a follow-up on PR antrea-io#5404 which intends to address issue antrea-io#5403. In upgrade cases, Antrea controller will still receive LabelIdentity add events for LabelIdentities created by previous controller, which it needs to handle correctly. Also, the stale controller logic needs to be updated to ensure that LabelIdentities created with old normalization method are cleaned up after upgrade. Signed-off-by: Dyanngg <dingyang@vmware.com>
tnqn
pushed a commit
that referenced
this pull request
Aug 29, 2023
…fter upgrade (#5449) This is a follow-up on PR #5404 which intends to address issue #5403. In upgrade cases, Antrea controller will still receive LabelIdentity add events for LabelIdentities created by previous controller, which it needs to handle correctly. Also, the stale controller logic needs to be updated to ensure that LabelIdentities created with old normalization method are cleaned up after upgrade. Signed-off-by: Dyanngg <dingyang@vmware.com>
luolanzone
pushed a commit
to luolanzone/antrea
that referenced
this pull request
Aug 29, 2023
…fter upgrade This is a follow-up on PR antrea-io#5404 which intends to address issue antrea-io#5403. In upgrade cases, Antrea controller will still receive LabelIdentity add events for LabelIdentities created by previous controller, which it needs to handle correctly. Also, the stale controller logic needs to be updated to ensure that LabelIdentities created with old normalization method are cleaned up after upgrade. Signed-off-by: Dyanngg <dingyang@vmware.com>
tnqn
pushed a commit
that referenced
this pull request
Aug 30, 2023
…fter upgrade (#5452) This is a follow-up on PR #5404 which intends to address issue #5403. In upgrade cases, Antrea controller will still receive LabelIdentity add events for LabelIdentities created by previous controller, which it needs to handle correctly. Also, the stale controller logic needs to be updated to ensure that LabelIdentities created with old normalization method are cleaned up after upgrade. Signed-off-by: Dyanngg <dingyang@vmware.com>
luolanzone
pushed a commit
to luolanzone/antrea
that referenced
this pull request
Aug 31, 2023
…fter upgrade This is a follow-up on PR antrea-io#5404 which intends to address issue antrea-io#5403. In upgrade cases, Antrea controller will still receive LabelIdentity add events for LabelIdentities created by previous controller, which it needs to handle correctly. Also, the stale controller logic needs to be updated to ensure that LabelIdentities created with old normalization method are cleaned up after upgrade. Signed-off-by: Dyanngg <dingyang@vmware.com>
luolanzone
pushed a commit
to luolanzone/antrea
that referenced
this pull request
Aug 31, 2023
…fter upgrade This is a follow-up on PR antrea-io#5404 which intends to address issue antrea-io#5403. In upgrade cases, Antrea controller will still receive LabelIdentity add events for LabelIdentities created by previous controller, which it needs to handle correctly. Also, the stale controller logic needs to be updated to ensure that LabelIdentities created with old normalization method are cleaned up after upgrade. Signed-off-by: Dyanngg <dingyang@vmware.com>
tnqn
pushed a commit
that referenced
this pull request
Aug 31, 2023
…fter upgrade (#5458) This is a follow-up on PR #5404 which intends to address issue #5403. In upgrade cases, Antrea controller will still receive LabelIdentity add events for LabelIdentities created by previous controller, which it needs to handle correctly. Also, the stale controller logic needs to be updated to ensure that LabelIdentities created with old normalization method are cleaned up after upgrade. Signed-off-by: Dyanngg <dingyang@vmware.com>
tnqn
pushed a commit
that referenced
this pull request
Aug 31, 2023
…fter upgrade (#5459) This is a follow-up on PR #5404 which intends to address issue #5403. In upgrade cases, Antrea controller will still receive LabelIdentity add events for LabelIdentities created by previous controller, which it needs to handle correctly. Also, the stale controller logic needs to be updated to ensure that LabelIdentities created with old normalization method are cleaned up after upgrade. Signed-off-by: Dyanngg <dingyang@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5403
When a Pod is created without any labels at all, its labelidentity will include
pod:<none>as defined by FormatLabels in apimachinery. This case is not handled correctly by the label group index and can cause the controller to crash.