Automated cherry pick of #5404: Fix controller issue in handling empty pod labels for #5424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a Pod is created without any labels at all, its labelidentity will include "pod:<none>" as defined by FormatLabels in apimachinery. This case is not handled correctly by the label group index and can cause the controller to crash. Signed-off-by: Dyanngg <dingyang@vmware.com>
luolanzone
added
the
kind/cherry-pick
Dyanngg
approved these changes
Aug 22, 2023
tnqn
approved these changes
Aug 23, 2023
|
/skip-all |
luolanzone
deleted the
automated-cherry-pick-of-#5404-upstream-release-1.11
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #5404 on release-1.11.
#5404: Fix controller issue in handling empty pod labels for
For details on the cherry pick process, see the cherry pick requests page.