Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(venn): 韦恩图交互增强（修复图例激活元素交互 & 增强active、highlight、selected交互） #2911

Merged
merged 13 commits into from
Oct 15, 2021
Merged

feat(venn): 韦恩图交互增强（修复图例激活元素交互 & 增强active、highlight、selected交互） #2911

merged 13 commits into from
Oct 15, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Oct 11, 2021 •
edited
Loading

PR includes

Screenshot

@visiky visiky requested a review from hustcc October 11, 2021 10:35
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2021 •
edited
Loading

🎊 PR Preview be5a36f has been successfully built and deployed to https://antvis-G2Plot-preview-pr-2911.surge.sh?type=diff&date=2021-10-15

🕐 Build time: 106.192s

🤖 By surge-preview

@visiky visiky marked this pull request as draft October 11, 2021 10:49
@visiky visiky removed the PR: draft label Oct 12, 2021
@pr-triage pr-triage bot added the PR: draft label Oct 12, 2021
@visiky visiky removed the PR: draft label Oct 12, 2021
@coveralls
Copy link

coveralls commented Oct 12, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1346571605

  • 8 of 8 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 95.631%
Totals Coverage Status
Change from base Build 1340932355: -0.01%
Covered Lines: 6786
Relevant Lines: 6908
💛 - Coveralls

@pr-triage pr-triage bot added the PR: draft label Oct 12, 2021
@visiky visiky linked an issue Oct 12, 2021 that may be closed by this pull request
🥰 [FEATURE] 韦恩图，active支持多选 #2907
Closed
@visiky visiky removed the PR: draft label Oct 12, 2021
@visiky visiky marked this pull request as ready for review October 12, 2021 09:12
visiky added 4 commits October 14, 2021 20:46
@visiky
feat(venn): 韦恩图颜色回调重构 (#2909)
d79726a 
* feat(venn): 韦恩图颜色回调重构

1. 修复 color 设置回调，导致图例颜色不正确
2. color 回调参数，增加 defaultColor 默认色
3. 完善韦恩图文档 & 增加 demo

* test(venn): 韦恩图单测

fix: #2906

* test(venn): 添加韦恩图 color 单测
@visiky
feat(venn): 韦恩图交互增强
368abe6 
修复图例激活元素交互 & 增强active、highlight、selected交互
@visiky
fix: types
3dfbe47
@visiky
refactor: 修改交互相关文件夹的命名
a35286c
@visiky visiky mentioned this pull request Oct 15, 2021
Closed
@visiky visiky merged commit ed5b71e into master Oct 15, 2021
@visiky visiky deleted the venn-interaction branch October 15, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] 咦，韦恩图，图例发现个bug 🥰 [FEATURE] 韦恩图，active支持多选
3 participants
@visiky @coveralls @hustcc