forked from solana-labs/solana
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.18: Revert deprecate executable feature (backport of #309) #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* revert deprecate executable feature * add native loader account transfer test --------- Co-authored-by: HaoranYi <haoran.yi@solana.com> (cherry picked from commit 0f8f8cd) # Conflicts: # programs/bpf_loader/src/lib.rs # runtime/src/accounts/mod.rs # runtime/src/bank.rs # runtime/src/bank/tests.rs # sdk/src/account.rs
Cherry-pick of 0f8f8cd has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Lichtso
approved these changes
Mar 20, 2024
pgarg66
approved these changes
Mar 20, 2024
This was referenced Mar 29, 2024
anwayde
pushed a commit
to firedancer-io/agave
that referenced
this pull request
Jul 23, 2024
…anza-xyz#337) * Revert deprecate executable feature (anza-xyz#309) * revert deprecate executable feature * add native loader account transfer test --------- Co-authored-by: HaoranYi <haoran.yi@solana.com> (cherry picked from commit 0f8f8cd) # Conflicts: # programs/bpf_loader/src/lib.rs # runtime/src/accounts/mod.rs # runtime/src/bank.rs # runtime/src/bank/tests.rs # sdk/src/account.rs * fix merge conflict * fix a test --------- Co-authored-by: HaoranYi <haoran.yi@gmail.com> Co-authored-by: HaoranYi <haoran.yi@solana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We reevaluated the feature to deprecate executable. We felt that this feature is
too complex and too risky for v1.18.
Therefore, we would like to revert this feature.
Summary of Changes
native_loader
owned accountFixes #
This is an automatic backport of pull request #309 done by [Mergify](https://mergify.com).