Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli tests: correct program data account test check #660

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

buffalojoec
Copy link

Problem

When going through #337 to narrow down root cause for #436, I noticed one small
error in a CLI unit test.

The original test was checking the program data account's executable field
here, not the program account.

Solution

Correct the one line in the test to check the program data account.

@buffalojoec buffalojoec requested a review from HaoranYi April 8, 2024 17:29
@buffalojoec buffalojoec force-pushed the cli-prog-test-check branch from a3ac55a to 3518208 Compare April 8, 2024 17:29
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.8%. Comparing base (0025ecd) to head (3518208).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #660     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         851      851             
  Lines      230370   230369      -1     
=========================================
- Hits       188669   188606     -63     
- Misses      41701    41763     +62     

Copy link

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. lgtm!

@buffalojoec buffalojoec merged commit caa18a5 into anza-xyz:master Apr 8, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants