Unconditionally flush the accounts bench stats when exiting #3958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveluscher
commented
Dec 5, 2024
Comment on lines
+338
to
+365
| fn flush_stats( | ||
| iters: &i32, | ||
| last_print: &mut Instant, | ||
| rpc_bench: &RpcBench, | ||
| stats: &mut RpcBenchStats, | ||
| thread: &usize, | ||
| ) { | ||
| info!( | ||
| "t({}) rpc({:?}) iters: {} success: {} errors: {}", | ||
| thread, rpc_bench, iters, stats.success, stats.errors | ||
| ); | ||
| if stats.success > 0 { | ||
| info!( | ||
| " t({}) rpc({:?} average success_time: {} us", | ||
| thread, | ||
| rpc_bench, | ||
| stats.total_success_time_us / stats.success | ||
| ); | ||
| } | ||
| if stats.errors > 0 { | ||
| info!( | ||
| " rpc average average errors time: {} us", | ||
| stats.total_errors_time_us / stats.errors | ||
| ); | ||
| } | ||
| *last_print = Instant::now(); | ||
| *stats = RpcBenchStats::default(); | ||
| } |
There was a problem hiding this comment.
Extracted this logic into a function so that I can call it in two places. I'm a Rust moron so please let me know if this isn't the idiomatic way. I tried creating a || {} closure, but ran into trouble with stats since its mutated outside.
steveluscher
added
the
automerge
|
automerge label removed due to a CI failure |
mergify
bot
removed
the
automerge
steveluscher
force-pushed
the
flush-those-logs
branch
from
bc2b28f to
543ce3b
Compare
steveluscher
force-pushed
the
flush-those-logs
branch
from
9f8d33f to
624135e
Compare
alessandrod
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When running the account benchmarks with a finite number of iterations, the final stats might not be logged. The logs are configured to print every 3 seconds.
Summary of Changes
This PR flushes them unconditionally when the exit signal is sent to the benchmark runner.
Related: #3242.