A benchmark suite for the getTransaction RPC call
#3987
Conversation
accounts-cluster-bench/src/main.rs
Outdated
| @@ -545,6 +633,8 @@ fn run_accounts_bench( | |||
| max_created: Arc::new(AtomicU64::default()), | |||
| max_closed: Arc::new(AtomicU64::default()), | |||
| }; | |||
| let transaction_signature_tracker = | |||
| TransactionSignatureTracker::new(RwLock::new(VecDeque::with_capacity(5000))); | |||
steveluscher
changed the title
getTransaction RPC call
steveluscher
force-pushed
the
transaction-rpc-bench
branch
3 times, most recently
from
ab0fdbf to
7813e55
Compare
accounts-cluster-bench/src/main.rs
Outdated
| @@ -130,6 +134,30 @@ struct SeedTracker { | |||
| max_closed: Arc<AtomicU64>, | |||
| } | |||
|
|
|||
| type TransactionSignatureTracker = Arc<RwLock<VecDeque<Signature>>>; | |||
There was a problem hiding this comment.
nit: I'd struct TransactionSignatureTracker(Arc<RwLock<...>)
it's not very idiomatic to use a trait for this. Also always add an empty
newline between item definitions
steveluscher
dismissed stale reviews from t-nelson and alessandrod
via
935673b
steveluscher
force-pushed
the
transaction-rpc-bench
branch
from
7813e55 to
935673b
Compare
|
Converted |
correctly enough. i usually prefer a struct with named field to 1-tuple form, 'cause |
accounts-cluster-bench/src/main.rs
Outdated
| struct TransactionSignatureTracker(Arc<RwLock<VecDeque<Signature>>>); | ||
|
|
||
| impl TransactionSignatureTracker { | ||
| fn clone(&self) -> TransactionSignatureTracker { |
There was a problem hiding this comment.
you can #[derive(Clone)] on the struct instead
steveluscher
force-pushed
the
transaction-rpc-bench
branch
from
935673b to
565a3c5
Compare
|
Update
|
steveluscher
dismissed stale reviews from t-nelson and alessandrod
via
55acaea
|
Resolved merge conflicts with |
|
Looks like this one broke CI: https://buildkite.com/anza/agave/builds/15544#0193ace5-f9fa-475e-91a2-81dd45120c13 Put in #4025 for it |
Summary of Changes
Note
Sometimes we get a
invalid type: null, expected struct EncodedConfirmedTransactionWithStatusMetaerror. Why is this? Is there a race between the time theexecutoraccepts the transactions and the time they can be fetched usingclient.get_transaction()?Related: #3242.