Reworked the SBF textual assembly syntax to match the rbpf-style syntax. #54

nvjle · 2022-11-15T04:50:28Z

Update the syntax of every instruction in SBFInstrInfo.td (currently using the asm variants feature to temporarily support both).
Update AsmParser for the new syntax (add new operand, memory, instruction, and directive parse routines).
Add error checking for unresolved 16-bit branch relocations and emit error message for graceful exit (the old BPF back-end crashes) and corresponding lit unit test.
Add new lit unit tests in MC/SBF and MC/Disassembler/SBF to cover disassembly, object emission, and parsing of every single instruction. This is more extensive coverage than existed previously.
Remaster all CodeGen/SBF unit tests accordingly.
A minor TableGen patch was needed to support asm strings containing '|' within variant strings ('|' happens to be the variant separator).

The patch is a bit more complex than it otherwise might be in that we currently support both syntaxes to ease the verification (e.g., being able to see and compare each instruction and object code side-by-side within each unit test). After some 'soak time' for the new functionality, I intend to remove the old syntax altogether and otherwise clean-up. We'll also remove the TableGen patch at that time.

- Update the syntax of every instruction in SBFInstrInfo.td (currently using the asm variants feature to temporarily support both). - Update AsmParser for the new syntax (add new operand, memory, instruction, and directive parse routines). - Add error checking for unresolved 16-bit branch relocations and emit error message for graceful exit (the old BPF back-end crashes) and corresponding lit unit test. - Add new lit unit tests in MC/SBF and MC/Disassembler/SBF to cover disassembly, object emission, and parsing of every single instruction. This is more extensive coverage than existed previously. - Remaster all CodeGen/SBF unit tests accordingly. - A minor TableGen patch was needed to support asm strings containing '|' within variant strings ('|' happens to be the variant separator). The patch is a bit more complex than it otherwise might be in that we currently support both syntaxes to ease the verification (e.g., being able to see and compare each instruction and object code side-by-side within each unit test). After some 'soak time' for the new functionality, I intend to remove the old syntax altogether and otherwise clean-up. We'll also remove the TableGen patch at that time.

Patch #54 originally reworked the SBF textual assembly syntax to match the rbpf-style syntax. In order to allow some soak-time, the above patch temporarily supported both the old and new syntax (selectable on the command line or via bespoke assembler directives). A little over a year has passed since then, and all is well with the new syntax, testing, and so forth. The current patch now removes all existing remnants of the old syntax-- including some of the target-independent changes made in the original patch to support both (e.g., a minor TableGen change for variants, some additional command line selector flags, etc). All related unit tests have been updated accordingly.

…e syntax. (anza-xyz#54) - Update the syntax of every instruction in SBFInstrInfo.td (currently using the asm variants feature to temporarily support both). - Update AsmParser for the new syntax (add new operand, memory, instruction, and directive parse routines). - Add error checking for unresolved 16-bit branch relocations and emit error message for graceful exit (the old BPF back-end crashes) and corresponding lit unit test. - Add new lit unit tests in MC/SBF and MC/Disassembler/SBF to cover disassembly, object emission, and parsing of every single instruction. This is more extensive coverage than existed previously. - Remaster all CodeGen/SBF unit tests accordingly. - A minor TableGen patch was needed to support asm strings containing '|' within variant strings ('|' happens to be the variant separator). The patch is a bit more complex than it otherwise might be in that we currently support both syntaxes to ease the verification (e.g., being able to see and compare each instruction and object code side-by-side within each unit test). After some 'soak time' for the new functionality, I intend to remove the old syntax altogether and otherwise clean-up. We'll also remove the TableGen patch at that time.

Patch anza-xyz#54 originally reworked the SBF textual assembly syntax to match the rbpf-style syntax. In order to allow some soak-time, the above patch temporarily supported both the old and new syntax (selectable on the command line or via bespoke assembler directives). A little over a year has passed since then, and all is well with the new syntax, testing, and so forth. The current patch now removes all existing remnants of the old syntax-- including some of the target-independent changes made in the original patch to support both (e.g., a minor TableGen change for variants, some additional command line selector flags, etc). All related unit tests have been updated accordingly.

…e syntax. (#54) - Update the syntax of every instruction in SBFInstrInfo.td (currently using the asm variants feature to temporarily support both). - Update AsmParser for the new syntax (add new operand, memory, instruction, and directive parse routines). - Add error checking for unresolved 16-bit branch relocations and emit error message for graceful exit (the old BPF back-end crashes) and corresponding lit unit test. - Add new lit unit tests in MC/SBF and MC/Disassembler/SBF to cover disassembly, object emission, and parsing of every single instruction. This is more extensive coverage than existed previously. - Remaster all CodeGen/SBF unit tests accordingly. - A minor TableGen patch was needed to support asm strings containing '|' within variant strings ('|' happens to be the variant separator). The patch is a bit more complex than it otherwise might be in that we currently support both syntaxes to ease the verification (e.g., being able to see and compare each instruction and object code side-by-side within each unit test). After some 'soak time' for the new functionality, I intend to remove the old syntax altogether and otherwise clean-up. We'll also remove the TableGen patch at that time.

Patch #54 originally reworked the SBF textual assembly syntax to match the rbpf-style syntax. In order to allow some soak-time, the above patch temporarily supported both the old and new syntax (selectable on the command line or via bespoke assembler directives). A little over a year has passed since then, and all is well with the new syntax, testing, and so forth. The current patch now removes all existing remnants of the old syntax-- including some of the target-independent changes made in the original patch to support both (e.g., a minor TableGen change for variants, some additional command line selector flags, etc). All related unit tests have been updated accordingly.

…e syntax. (anza-xyz#54) - Update the syntax of every instruction in SBFInstrInfo.td (currently using the asm variants feature to temporarily support both). - Update AsmParser for the new syntax (add new operand, memory, instruction, and directive parse routines). - Add error checking for unresolved 16-bit branch relocations and emit error message for graceful exit (the old BPF back-end crashes) and corresponding lit unit test. - Add new lit unit tests in MC/SBF and MC/Disassembler/SBF to cover disassembly, object emission, and parsing of every single instruction. This is more extensive coverage than existed previously. - Remaster all CodeGen/SBF unit tests accordingly. - A minor TableGen patch was needed to support asm strings containing '|' within variant strings ('|' happens to be the variant separator). The patch is a bit more complex than it otherwise might be in that we currently support both syntaxes to ease the verification (e.g., being able to see and compare each instruction and object code side-by-side within each unit test). After some 'soak time' for the new functionality, I intend to remove the old syntax altogether and otherwise clean-up. We'll also remove the TableGen patch at that time.

Patch anza-xyz#54 originally reworked the SBF textual assembly syntax to match the rbpf-style syntax. In order to allow some soak-time, the above patch temporarily supported both the old and new syntax (selectable on the command line or via bespoke assembler directives). A little over a year has passed since then, and all is well with the new syntax, testing, and so forth. The current patch now removes all existing remnants of the old syntax-- including some of the target-independent changes made in the original patch to support both (e.g., a minor TableGen change for variants, some additional command line selector flags, etc). All related unit tests have been updated accordingly.

…e syntax. (#54) - Update the syntax of every instruction in SBFInstrInfo.td (currently using the asm variants feature to temporarily support both). - Update AsmParser for the new syntax (add new operand, memory, instruction, and directive parse routines). - Add error checking for unresolved 16-bit branch relocations and emit error message for graceful exit (the old BPF back-end crashes) and corresponding lit unit test. - Add new lit unit tests in MC/SBF and MC/Disassembler/SBF to cover disassembly, object emission, and parsing of every single instruction. This is more extensive coverage than existed previously. - Remaster all CodeGen/SBF unit tests accordingly. - A minor TableGen patch was needed to support asm strings containing '|' within variant strings ('|' happens to be the variant separator). The patch is a bit more complex than it otherwise might be in that we currently support both syntaxes to ease the verification (e.g., being able to see and compare each instruction and object code side-by-side within each unit test). After some 'soak time' for the new functionality, I intend to remove the old syntax altogether and otherwise clean-up. We'll also remove the TableGen patch at that time.

Patch #54 originally reworked the SBF textual assembly syntax to match the rbpf-style syntax. In order to allow some soak-time, the above patch temporarily supported both the old and new syntax (selectable on the command line or via bespoke assembler directives). A little over a year has passed since then, and all is well with the new syntax, testing, and so forth. The current patch now removes all existing remnants of the old syntax-- including some of the target-independent changes made in the original patch to support both (e.g., a minor TableGen change for variants, some additional command line selector flags, etc). All related unit tests have been updated accordingly.

nvjle requested a review from dmakarov November 15, 2022 04:50

nvjle self-assigned this Nov 15, 2022

dmakarov approved these changes Nov 15, 2022

View reviewed changes

nvjle merged commit 4d40f82 into solana-rustc/14.0-2022-03-22 Nov 15, 2022

nvjle mentioned this pull request Dec 12, 2023

[SOL] Remove now obsolete old syntax bits. #72

Merged

dmakarov deleted the jle-new-asm-syntax branch February 14, 2024 21:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reworked the SBF textual assembly syntax to match the rbpf-style syntax. #54

Reworked the SBF textual assembly syntax to match the rbpf-style syntax. #54

nvjle commented Nov 15, 2022

Reworked the SBF textual assembly syntax to match the rbpf-style syntax. #54

Reworked the SBF textual assembly syntax to match the rbpf-style syntax. #54

Conversation

nvjle commented Nov 15, 2022