[SOL] Remove now obsolete old syntax bits. #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch #54 originally reworked the SBF textual assembly syntax to match the rbpf-style syntax. In order to allow some soak-time, the above patch temporarily supported both the old and new syntax (selectable on the command line or via bespoke assembler directives). A little over a year has passed since then, and all is well with the new syntax, testing, and so forth. The current patch now removes all existing remnants of the old syntax-- including some of the target-independent changes made in the original patch to support both (e.g., a minor TableGen change for variants, some additional command line selector flags, etc). All related unit tests have been updated accordingly.
dmakarov
approved these changes
Dec 12, 2023
LucasSte
pushed a commit
to LucasSte/llvm-project
that referenced
this pull request
Jan 31, 2024
Patch anza-xyz#54 originally reworked the SBF textual assembly syntax to match the rbpf-style syntax. In order to allow some soak-time, the above patch temporarily supported both the old and new syntax (selectable on the command line or via bespoke assembler directives). A little over a year has passed since then, and all is well with the new syntax, testing, and so forth. The current patch now removes all existing remnants of the old syntax-- including some of the target-independent changes made in the original patch to support both (e.g., a minor TableGen change for variants, some additional command line selector flags, etc). All related unit tests have been updated accordingly.
LucasSte
pushed a commit
that referenced
this pull request
Feb 16, 2024
Patch #54 originally reworked the SBF textual assembly syntax to match the rbpf-style syntax. In order to allow some soak-time, the above patch temporarily supported both the old and new syntax (selectable on the command line or via bespoke assembler directives). A little over a year has passed since then, and all is well with the new syntax, testing, and so forth. The current patch now removes all existing remnants of the old syntax-- including some of the target-independent changes made in the original patch to support both (e.g., a minor TableGen change for variants, some additional command line selector flags, etc). All related unit tests have been updated accordingly.
LucasSte
pushed a commit
to LucasSte/llvm-project
that referenced
this pull request
Jun 28, 2024
Patch anza-xyz#54 originally reworked the SBF textual assembly syntax to match the rbpf-style syntax. In order to allow some soak-time, the above patch temporarily supported both the old and new syntax (selectable on the command line or via bespoke assembler directives). A little over a year has passed since then, and all is well with the new syntax, testing, and so forth. The current patch now removes all existing remnants of the old syntax-- including some of the target-independent changes made in the original patch to support both (e.g., a minor TableGen change for variants, some additional command line selector flags, etc). All related unit tests have been updated accordingly.
LucasSte
pushed a commit
that referenced
this pull request
Aug 19, 2024
Patch #54 originally reworked the SBF textual assembly syntax to match the rbpf-style syntax. In order to allow some soak-time, the above patch temporarily supported both the old and new syntax (selectable on the command line or via bespoke assembler directives). A little over a year has passed since then, and all is well with the new syntax, testing, and so forth. The current patch now removes all existing remnants of the old syntax-- including some of the target-independent changes made in the original patch to support both (e.g., a minor TableGen change for variants, some additional command line selector flags, etc). All related unit tests have been updated accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch #54 originally reworked the SBF textual assembly syntax to match the rbpf-style syntax.
In order to allow some soak-time, the above patch temporarily supported both the old and new syntax (selectable on the command line or via bespoke assembler directives). A little over a year has passed since then, and all is well with the new syntax, testing, and so forth.
The current patch now removes all existing remnants of the old syntax-- including some of the target-independent changes made in the original patch to support both (e.g., a minor TableGen change for variants, some additional command line selector flags, etc).
All related unit tests have been updated accordingly.