Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of testing Providers that were prepared on April 09, 2023 #30553

Closed
13 of 16 tasks
eladkal opened this issue Apr 9, 2023 · 17 comments
Closed
13 of 16 tasks

Status of testing Providers that were prepared on April 09, 2023 #30553

eladkal opened this issue Apr 9, 2023 · 17 comments
Labels
kind:meta High-level information important to the community testing status Status of testing releases

Comments

@eladkal
Copy link
Contributor

eladkal commented Apr 9, 2023

I have a kind request for all the contributors to the latest provider packages release.
Could you please help us to test the RC versions of the providers?

Let us know in the comment, whether the issue is addressed.

Those are providers that require testing as there were some substantial changes introduced:

Provider amazon: 7.4.1rc1

Provider cncf.kubernetes: 6.0.0rc1

Provider google: 9.0.0rc1

Provider microsoft.azure: 5.3.1rc1

Provider smtp: 1.0.1rc1

The guidelines on how to test providers can be found in

Verify providers by contributors

All users involved in the PRs:
@happilyeverafter95 @dolfinus @VladaZakharova @phanikumv @potiuk @tnk-ysk @hussein-awala @vandonr-amz @vanducng @vchiapaikeo @lwyszomi

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@eladkal eladkal added kind:meta High-level information important to the community testing status Status of testing releases labels Apr 9, 2023
@vanducng
Copy link
Contributor

vanducng commented Apr 9, 2023

Confirm #30524 bug already got fixed in smtp: 1.0.1rc1. Thanks.

@vandonr-amz
Copy link
Contributor

👍

@vanducng
Copy link
Contributor

vanducng commented Apr 9, 2023

google: 9.0.0rc1 also works well with our google ads and dv360 task.

@vchiapaikeo
Copy link
Contributor

#30543 also still looks fine. Thank you, Elad!

image

@potiuk
Copy link
Member

potiuk commented Apr 9, 2023

google: 9.0.0rc1 also works well with our google ads and dv360 task.

🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉

@potiuk
Copy link
Member

potiuk commented Apr 9, 2023

Tested mine. All works.

@raphaelauv
Copy link
Contributor

raphaelauv commented Apr 9, 2023

Use default connection id for KubernetesPodOperator (#28848)

work

@hussein-awala
Copy link
Member

@tnk-ysk
Copy link
Contributor

tnk-ysk commented Apr 10, 2023

I tested #30441, it works as expected

@eladkal
Copy link
Contributor Author

eladkal commented Apr 10, 2023

#30514 -> it works with the connections created via the Airflow CLI (as I did when I tested the PR before), but not directly with the connections created from the UI, I created #30556 to describe and fix the problem, and #30557 to clean the Azure provider code. Since we can create the connection from the CLI or the environment variables, and even we can edit the UI connection manually once it is created, no need to block the release and create a new one, we can add the fix (and maybe the full clean) to the next release.

since this is the only fix in the release for azure I tend to drop azure from this wave. I think it's preferred to cut RC2 after the fixes are ready

@potiuk
Copy link
Member

potiuk commented Apr 10, 2023

since this is the only fix in the release for azure I tend to drop azure from this wave. I think it's preferred to cut RC2 after the fixes are ready

We could also apply what we agreed about - shorter voting period for RC2+

We could potentially merge the fix now, prepare RC2 for azure only and release them all together when voting period ends. Might be good time to try this method to see if there is anything to fix in our process to follow this route.

@eladkal
Copy link
Contributor Author

eladkal commented Apr 10, 2023

We could also apply what we agreed about - shorter voting period for RC2+

This is what I plan to do but this will work only if there aren't other changes for azure that were merged in the mean time. I didn't check yet.

@potiuk
Copy link
Member

potiuk commented Apr 10, 2023

We will need an RC2 for google provider too - (found by @cgadam - fix in #30564).

@utkarsharma2
Copy link
Contributor

Works well with AstroSDk.

@phanikumv
Copy link
Contributor

#30370 works well.

2023-04-10, 14:00:26 UTC] {standard_task_runner.py:55} INFO - Started process 3123 to run task
[2023-04-10, 14:00:26 UTC] {standard_task_runner.py:82} INFO - Running: ['***', 'tasks', 'run', 'example_async_redshift_cluster_management', 'resume_redshift_cluster', 'manual__2023-04-10T13:55:51.894401+00:00', '--job-id', '10', '--raw', '--subdir', 'DAGS_FOLDER/example_redshift_cluster_management.py', '--cfg-path', '/tmp/tmpsyc34091']
[2023-04-10, 14:00:26 UTC] {standard_task_runner.py:83} INFO - Job 10: Subtask resume_redshift_cluster
[2023-04-10, 14:00:26 UTC] {task_command.py:389} INFO - Running <TaskInstance: example_async_redshift_cluster_management.resume_redshift_cluster manual__2023-04-10T13:55:51.894401+00:00 [running]> on host 101451e0c77b
[2023-04-10, 14:00:26 UTC] {redshift_cluster.py:472} INFO - resume_redshift_cluster completed successfully.
[2023-04-10, 14:00:26 UTC] {redshift_cluster.py:473} INFO - Resumed cluster successfully

@eladkal
Copy link
Contributor Author

eladkal commented Apr 12, 2023

microsoft.azure and google will be excluded from rc1.
I will cut rc2 as soon as other providers are released.

@eladkal
Copy link
Contributor Author

eladkal commented Apr 12, 2023

Thank you everyone.
The google and microsoft.azure providers are excluded from the release and RC2 will be cut for them shortly.
other providers are released.
I invite everyone to help improve providers for the next release, a list of open issues can be found here.

@eladkal eladkal closed this as completed Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:meta High-level information important to the community testing status Status of testing releases
Projects
None yet
Development

No branches or pull requests

10 participants