Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RedshiftResumeClusterOperator deferrable implementation #30370

Merged
merged 3 commits into from
Apr 3, 2023

Conversation

phanikumv
Copy link
Contributor

@phanikumv phanikumv commented Mar 30, 2023

This PR fixes the bug on RedshiftResumeClusterOperator implementation when deferrable flag is set to True
Related to #30090


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:amazon-aws AWS/Amazon - related issues labels Mar 30, 2023
@phanikumv
Copy link
Contributor Author

phanikumv commented Mar 30, 2023

Logs showing successful task execution

image

[2023-03-30, 16:26:42 UTC] {taskinstance.py:1326} INFO - Resuming after deferral [2023-03-30, 16:26:42 UTC] {taskinstance.py:1347} INFO - Executing <Task(RedshiftResumeClusterOperator): resume_redshift_cluster> on 2023-03-30 16:18:42.456898+00:00 [2023-03-30, 16:26:42 UTC] {standard_task_runner.py:56} INFO - Started process 1542 to run task [2023-03-30, 16:26:42 UTC] {standard_task_runner.py:83} INFO - Running: ['airflow', 'tasks', 'run', 'example_async_redshift_cluster_management', 'resume_redshift_cluster', 'manual__2023-03-30T16:18:42.456898+00:00', '--job-id', '37', '--raw', '--subdir', 'DAGS_FOLDER/example_redshift_cluster_management.py', '--cfg-path', '/tmp/tmppxlt9doz'] [2023-03-30, 16:26:42 UTC] {standard_task_runner.py:84} INFO - Job 37: Subtask resume_redshift_cluster [2023-03-30, 16:26:42 UTC] {task_command.py:407} INFO - Running <TaskInstance: example_async_redshift_cluster_management.resume_redshift_cluster manual__2023-03-30T16:18:42.456898+00:00 [running]> on host f164302965b9 [2023-03-30, 16:26:43 UTC] {redshift_cluster.py:472} INFO - resume_redshift_cluster completed successfully. [2023-03-30, 16:26:43 UTC] {redshift_cluster.py:473} INFO - Resumed cluster successfully

@phanikumv phanikumv marked this pull request as ready for review March 30, 2023 17:19
@phanikumv
Copy link
Contributor Author

@syedahsn could you please review this PR

@potiuk potiuk merged commit 8bf4f62 into apache:main Apr 3, 2023
@potiuk
Copy link
Member

potiuk commented Apr 3, 2023

Yeah. a bit too late @phanikumv -> the next release. BTW. For the future - when we prepare for release we announce it it's a time to advocate for the important ones to be merged :D

https://apache-airflow.slack.com/archives/CCPRP7943/p1679926872390929

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants