Update DV360 operators to use API v2 #30326
Conversation
boring-cyborg
bot
added
area:providers
kind:documentation
provider:google
|
Does this PR closes #28045 ? |
|
@eladkal most important part yes, regarding queries/reports |
| @@ -23,6 +23,15 @@ | |||
| Changelog | |||
| --------- | |||
|
|
|||
| 9.0.0 | |||
There was a problem hiding this comment.
I wonder if our tooling will break when we get to 10 here. Let's see 🤔
There was a problem hiding this comment.
Something is odd.
I would have expected to CI complain about need to add deprecated operators to:
airflow/tests/always/test_project_structure.py
Lines 251 to 269 in 4effd6f
airflow/providers/google/marketing_platform/operators/display_video.py
Outdated
Show resolved
Hide resolved
airflow/providers/google/marketing_platform/operators/display_video.py
Outdated
Show resolved
Hide resolved
xfail = "expected to fail" Not sure who marked it as such, but that's the reason it did not fail the build |
lwyszomi
force-pushed
the
dv360-update
branch
2 times, most recently
from
1eda3cb
to
eb682a9
Compare
|
doc build is failing |
|
I (think) fixed the error and rebased it, so that we can merge it and release in the ad-hoc release of Google Provider (cc: @eladkal ) |
|
cc: @lwyszomi ^^ |
There was a problem hiding this comment.
I'm pretty sure the doc build is failing because this PR adds new operators but they are not listed in provider.yaml
can you please check it?
There was a problem hiding this comment.
That was not the reason.
Operators are never listed "individually" in provider.yaml - only Hooks are listed when they are contributing new connection types.
The problems
I fixed the build and there were three problems:
- there was an apostrophe instead of
backtickaround the http link added:
`https://developers.google.com/bid-manager/v2/queries/delete'
Should be:
`https://developers.google.com/bid-manager/v2/queries/delete`
Small difference and not easy to spot the error, but it was enough to make sphinx generation freak-out and produce error messages that were completely misleading.
- There is still a bit problem with the new links generated (some of them are copy&pasted
Solutions
So I applied three solutions:
- replaced the
'withbacktick - i manually removed the anchors to stop the docs from failing but the final fix is stil waiting for @lwyszomi
There was a problem hiding this comment.
@potiuk you are the god, how you found this apostrophe, I tried to understand whole friday why it failing and why error is shown in the generated files without any "real" suggestion. Sorry I was whole weekend offline, Easter holidays. Today I will prepared needed changes.
There was a problem hiding this comment.
:D I am just intimately familiar with Sphinxes :) and I know they speak in riddles.
And yes it took me quite a bit of bisecting to find out (this is the technique I often use when I am at a loss and remove parts of the commits to narrow down the search.
What also helped is #30555 and I think we should - at the very least make it possible to have incremental builds for the docs (only changed parts) - but I referained from diggung into it as we are likely to improve the whole stack of docs building HOPEFULLY soon. Or maybe just allow partial generation of only subset of provider. That could have helped with bisecting and iterations immensely in such cases.
Release google provider package v2023.4.3: apache/airflow#30326 apache/airflow#29234 Change-Id: I03928b0d940b710ff40d6c6de61519f99954dbee GitOrigin-RevId: eb05386e3782b85dd1bcd11127ecf2204c1751ff
Support latest version of Display Video 360 API, because v1 and v1.1 will be sunset soon.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.