Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.7.X should add dep constraint: "connexion<3" #35217

Closed
2 tasks done
Kache opened this issue Oct 27, 2023 · 1 comment · Fixed by #35218
Closed
2 tasks done

2.7.X should add dep constraint: "connexion<3" #35217

Kache opened this issue Oct 27, 2023 · 1 comment · Fixed by #35218
Labels
area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet

Comments

@Kache
Copy link
Contributor

Kache commented Oct 27, 2023

Apache Airflow version

2.7.2

What happened

Dep declared at: https://github.com/apache/airflow/blob/2.7.2/setup.cfg#L81

When using connexion==3.0.0a7:

martech-airflow-scheduler-1  | Traceback (most recent call last):
martech-airflow-scheduler-1  |   File "/app/.venv/bin/airflow", line 8, in <module>
martech-airflow-scheduler-1  |     sys.exit(main())
martech-airflow-scheduler-1  |              ^^^^^^
martech-airflow-scheduler-1  |   File "/app/.venv/lib/python3.11/site-packages/airflow/__main__.py", line 59, in main
martech-airflow-scheduler-1  |     args.func(args)
martech-airflow-scheduler-1  |   File "/app/.venv/lib/python3.11/site-packages/airflow/cli/cli_config.py", line 49, in command
martech-airflow-scheduler-1  |     return func(*args, **kwargs)
martech-airflow-scheduler-1  |            ^^^^^^^^^^^^^^^^^^^^^
martech-airflow-scheduler-1  |   File "/app/.venv/lib/python3.11/site-packages/airflow/utils/providers_configuration_loader.py", line 55, in wrapped_function
martech-airflow-scheduler-1  |     return func(*args, **kwargs)
martech-airflow-scheduler-1  |            ^^^^^^^^^^^^^^^^^^^^^
martech-airflow-scheduler-1  |   File "/app/.venv/lib/python3.11/site-packages/airflow/cli/commands/db_command.py", line 186, in check_migrations
martech-airflow-scheduler-1  |     db.check_migrations(timeout=args.migration_wait_timeout)
martech-airflow-scheduler-1  |   File "/app/.venv/lib/python3.11/site-packages/airflow/utils/db.py", line 793, in check_migrations
martech-airflow-scheduler-1  |     source_heads = set(env.script.get_heads())
martech-airflow-scheduler-1  |                        ^^^^^^^^^^^^^^^^^^^^^^
martech-airflow-scheduler-1  |   File "/app/.venv/lib/python3.11/site-packages/alembic/script/base.py", line 406, in get_heads
martech-airflow-scheduler-1  |     return list(self.revision_map.heads)
martech-airflow-scheduler-1  |                 ^^^^^^^^^^^^^^^^^^^^^^^
martech-airflow-scheduler-1  |   File "/app/.venv/lib/python3.11/site-packages/sqlalchemy/util/langhelpers.py", line 1113, in __get__
martech-airflow-scheduler-1  |     obj.__dict__[self.__name__] = result = self.fget(obj)
martech-airflow-scheduler-1  |                                            ^^^^^^^^^^^^^^
martech-airflow-scheduler-1  |   File "/app/.venv/lib/python3.11/site-packages/alembic/script/revision.py", line 137, in heads
martech-airflow-scheduler-1  |     self._revision_map
martech-airflow-scheduler-1  |   File "/app/.venv/lib/python3.11/site-packages/sqlalchemy/util/langhelpers.py", line 1113, in __get__
martech-airflow-scheduler-1  |     obj.__dict__[self.__name__] = result = self.fget(obj)
martech-airflow-scheduler-1  |                                            ^^^^^^^^^^^^^^
martech-airflow-scheduler-1  |   File "/app/.venv/lib/python3.11/site-packages/alembic/script/revision.py", line 191, in _revision_map
martech-airflow-scheduler-1  |     for revision in self._generator():
martech-airflow-scheduler-1  |   File "/app/.venv/lib/python3.11/site-packages/alembic/script/base.py", line 148, in _load_revisions
martech-airflow-scheduler-1  |     script = Script._from_filename(self, dir_name, filename)
martech-airflow-scheduler-1  |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
martech-airflow-scheduler-1  |   File "/app/.venv/lib/python3.11/site-packages/alembic/script/base.py", line 1036, in _from_filename
martech-airflow-scheduler-1  |     module = util.load_python_file(dir_, filename)
martech-airflow-scheduler-1  |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
martech-airflow-scheduler-1  |   File "/app/.venv/lib/python3.11/site-packages/alembic/util/pyfiles.py", line 93, in load_python_file
martech-airflow-scheduler-1  |     module = load_module_py(module_id, path)
martech-airflow-scheduler-1  |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
martech-airflow-scheduler-1  |   File "/app/.venv/lib/python3.11/site-packages/alembic/util/pyfiles.py", line 109, in load_module_py
martech-airflow-scheduler-1  |     spec.loader.exec_module(module)  # type: ignore
martech-airflow-scheduler-1  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
martech-airflow-scheduler-1  |   File "<frozen importlib._bootstrap_external>", line 940, in exec_module
martech-airflow-scheduler-1  |   File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
martech-airflow-scheduler-1  |   File "/var/app/.venv/lib/python3.11/site-packages/airflow/migrations/versions/0074_2_0_0_resource_based_permissions.py", line 30, in <module>
martech-airflow-scheduler-1  |     from airflow.www.app import cached_app
martech-airflow-scheduler-1  |   File "/app/.venv/lib/python3.11/site-packages/airflow/www/app.py", line 50, in <module>
martech-airflow-scheduler-1  |     from airflow.www.extensions.init_views import (
martech-airflow-scheduler-1  |   File "/app/.venv/lib/python3.11/site-packages/airflow/www/extensions/init_views.py", line 27, in <module>
martech-airflow-scheduler-1  |     from connexion.decorators.validation import RequestBodyValidator
martech-airflow-scheduler-1  | ModuleNotFoundError: No module named 'connexion.decorators.validation'

What you think should happen instead

Have upper bound constraint

or add dynamic branches that support connexion v3 (j/k)

How to reproduce

start up airflow with connexion==3.0.0a7

Operating System

Debian GNU/Linux 12 (bookworm)

Versions of Apache Airflow Providers

No response

Deployment

Docker-Compose

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@Kache Kache added area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Oct 27, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 27, 2023

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

potiuk pushed a commit to Kache/airflow that referenced this issue Oct 28, 2023
otherwise, breakage at import: airflow/www/extensions/init_views.py

Fix: apache/issues/35217
potiuk added a commit that referenced this issue Oct 28, 2023
* Add connexion<3.0 upper bound

otherwise, breakage at import: airflow/www/extensions/init_views.py

Fix: /issues/35217

* Update setup.cfg

* Update setup.cfg

---------

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk pushed a commit that referenced this issue Oct 29, 2023
* Add connexion<3.0 upper bound

otherwise, breakage at import: airflow/www/extensions/init_views.py

Fix: /issues/35217

* Update setup.cfg

* Update setup.cfg

---------

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
(cherry picked from commit f592b2c)
ahidalgob pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue May 15, 2024
* Add connexion<3.0 upper bound

otherwise, breakage at import: airflow/www/extensions/init_views.py

Fix: apache/airflow/issues/35217

* Update setup.cfg

* Update setup.cfg

---------

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
(cherry picked from commit f592b2c40bd23a7bb1e3b471e47c5d1968f70a45)
GitOrigin-RevId: e30fd42e8700700f6f3e5bd7c20736eb4bf52f2d
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Jul 18, 2024
* Add connexion<3.0 upper bound

otherwise, breakage at import: airflow/www/extensions/init_views.py

Fix: apache/airflow/issues/35217

* Update setup.cfg

* Update setup.cfg

---------

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
GitOrigin-RevId: f592b2c40bd23a7bb1e3b471e47c5d1968f70a45
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Sep 20, 2024
* Add connexion<3.0 upper bound

otherwise, breakage at import: airflow/www/extensions/init_views.py

Fix: apache/airflow/issues/35217

* Update setup.cfg

* Update setup.cfg

---------

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
GitOrigin-RevId: f592b2c40bd23a7bb1e3b471e47c5d1968f70a45
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Nov 8, 2024
* Add connexion<3.0 upper bound

otherwise, breakage at import: airflow/www/extensions/init_views.py

Fix: apache/airflow/issues/35217

* Update setup.cfg

* Update setup.cfg

---------

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
GitOrigin-RevId: f592b2c40bd23a7bb1e3b471e47c5d1968f70a45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant