-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add connexion<3.0 upper bound #35218
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
@@ -79,7 +79,7 @@ install_requires = | |||
# Update CustomTTYColoredFormatter to remove | |||
colorlog>=4.0.2, <5.0 | |||
configupdater>=3.1.1 | |||
connexion[flask]>=2.10.0 | |||
connexion[flask]>=2.10.0,<3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usual when we upper bound limit some package we add couple words about what the reason for it, and further steps to remove this limitation.
Could you also add this info?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. We need an explanation for that. Generally you should use constraints where you install airflow from scratch to achieve reproducible builds https://airflow.apache.org/docs/apache-airflow/stable/installation/installing-from-pypi.html - so lack of "upper-binding" is EXPECTED in most dependencies. We need to have a good reason and explanation to upper-bind it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or - even better - we need a fix for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'd just thought the git commit message was sufficient. I'll add some source comments
we need a fix for that
Like adding a dynamic branch based on connexion version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Either commit explaining why we need it and what we are waiting for or containing a fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the added comment sufficient? It would be difficult for me to be any more specific, given my limited familiarity with Airflow internals and connexion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix would be better if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just making sure it won't get merged without good reason/explanation
940cda8
to
f93fc95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comments, looks good now.
Committed the link and rebased to build again. |
otherwise, breakage at import: airflow/www/extensions/init_views.py Fix: apache/issues/35217
69ea628
to
1ec459e
Compare
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
* Add connexion<3.0 upper bound otherwise, breakage at import: airflow/www/extensions/init_views.py Fix: /issues/35217 * Update setup.cfg * Update setup.cfg --------- Co-authored-by: Jarek Potiuk <jarek@potiuk.com> (cherry picked from commit f592b2c)
otherwise, breakage at import: airflow/www/extensions/init_views.py
Fix: /issues/35217