Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connexion<3.0 upper bound #35218

Merged
merged 3 commits into from
Oct 28, 2023
Merged

Conversation

Kache
Copy link
Contributor

@Kache Kache commented Oct 27, 2023

otherwise, breakage at import: airflow/www/extensions/init_views.py

Fix: /issues/35217

@boring-cyborg
Copy link

boring-cyborg bot commented Oct 27, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@@ -79,7 +79,7 @@ install_requires =
# Update CustomTTYColoredFormatter to remove
colorlog>=4.0.2, <5.0
configupdater>=3.1.1
connexion[flask]>=2.10.0
connexion[flask]>=2.10.0,<3.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usual when we upper bound limit some package we add couple words about what the reason for it, and further steps to remove this limitation.
Could you also add this info?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We need an explanation for that. Generally you should use constraints where you install airflow from scratch to achieve reproducible builds https://airflow.apache.org/docs/apache-airflow/stable/installation/installing-from-pypi.html - so lack of "upper-binding" is EXPECTED in most dependencies. We need to have a good reason and explanation to upper-bind it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or - even better - we need a fix for that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'd just thought the git commit message was sufficient. I'll add some source comments

we need a fix for that

Like adding a dynamic branch based on connexion version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Either commit explaining why we need it and what we are waiting for or containing a fix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the added comment sufficient? It would be difficult for me to be any more specific, given my limited familiarity with Airflow internals and connexion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix would be better if possible.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just making sure it won't get merged without good reason/explanation

@Kache Kache force-pushed the add-connexion-upper-bound branch 3 times, most recently from 940cda8 to f93fc95 Compare October 27, 2023 22:22
@Taragolis Taragolis added this to the Airflow 2.7.3 milestone Oct 27, 2023
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments, looks good now.

setup.cfg Show resolved Hide resolved
@potiuk
Copy link
Member

potiuk commented Oct 28, 2023

Committed the link and rebased to build again.

Kache and others added 2 commits October 28, 2023 16:26
otherwise, breakage at import: airflow/www/extensions/init_views.py

Fix: apache/issues/35217
setup.cfg Outdated Show resolved Hide resolved
@potiuk potiuk merged commit f592b2c into apache:main Oct 28, 2023
67 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 28, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

potiuk pushed a commit that referenced this pull request Oct 29, 2023
* Add connexion<3.0 upper bound

otherwise, breakage at import: airflow/www/extensions/init_views.py

Fix: /issues/35217

* Update setup.cfg

* Update setup.cfg

---------

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
(cherry picked from commit f592b2c)
@potiuk potiuk added the type:misc/internal Changelog: Misc changes that should appear in change log label Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.7.X should add dep constraint: "connexion<3"
4 participants