-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add werkzeug limitation until flask-login will handle it #25270
Conversation
Could you add a comment above the line (just repeat the PR description would do) so we can more easily understand why the upper bound is there afterwards? |
@uranusjr thanks for fast feedback |
Thanks @rino0601 ! - I was just looking at some early warnings from some of our PRs failing, resulting from this error ! |
I also commented in the issue maxcountryman/flask-login#686 (comment) - this is I thin 3rd time over 3 years that we experienced some Werkzeug + Flask Login compatibilty issues and I think it would be great if maintainers of those two project will get to cooperat a bit more to make sure they are not breaking other's code. I'd appreciate some encouragement there, maybe we can improve the world a bit around us :) |
The Werkzeug limitation removed in apache#25270 can be removed now, when Flask-login is fixed and 0.6.2 version is released that supports it.
The Werkzeug limitation removed in #25270 can be removed now, when Flask-login is fixed and 0.6.2 version is released that supports it.
related: #25269
werkzeoug 2.2.0 breaks flask-login.
This will be problem who doesn't use
pip --constraint
The breaks caused by pallets/werkzeug#2433 and flask-login already knows it maxcountryman/flask-login#686
I think we need werkzeug<2.2 limitation until flask_login are handle it
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.