Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add werkzeug limitation until flask-login will handle it #25270

Merged
merged 2 commits into from
Jul 25, 2022

Conversation

rino0601
Copy link
Contributor

related: #25269

werkzeoug 2.2.0 breaks flask-login.
This will be problem who doesn't use pip --constraint

The breaks caused by pallets/werkzeug#2433 and flask-login already knows it maxcountryman/flask-login#686

I think we need werkzeug<2.2 limitation until flask_login are handle it


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@uranusjr
Copy link
Member

Could you add a comment above the line (just repeat the PR description would do) so we can more easily understand why the upper bound is there afterwards?

@rino0601
Copy link
Contributor Author

@uranusjr thanks for fast feedback
I just added comment as you requested.

@potiuk potiuk merged commit bb5a8ec into apache:main Jul 25, 2022
@potiuk
Copy link
Member

potiuk commented Jul 25, 2022

Thanks @rino0601 ! - I was just looking at some early warnings from some of our PRs failing, resulting from this error !

@potiuk
Copy link
Member

potiuk commented Jul 25, 2022

I also commented in the issue maxcountryman/flask-login#686 (comment) - this is I thin 3rd time over 3 years that we experienced some Werkzeug + Flask Login compatibilty issues and I think it would be great if maintainers of those two project will get to cooperat a bit more to make sure they are not breaking other's code.

I'd appreciate some encouragement there, maybe we can improve the world a bit around us :)

potiuk added a commit to potiuk/airflow that referenced this pull request Jul 27, 2022
The Werkzeug limitation removed in apache#25270 can be removed now, when
Flask-login is fixed and 0.6.2 version is released that supports it.
potiuk added a commit that referenced this pull request Jul 27, 2022
The Werkzeug limitation removed in #25270 can be removed now, when
Flask-login is fixed and 0.6.2 version is released that supports it.
potiuk added a commit that referenced this pull request Aug 4, 2022
The Werkzeug limitation removed in #25270 can be removed now, when
Flask-login is fixed and 0.6.2 version is released that supports it.

(cherry picked from commit dbbe9ac)
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Aug 15, 2022
@ephraimbuddy ephraimbuddy added this to the Airflow 2.4.0 milestone Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants