Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Werkzeug limitation after flask-login was fixed #25291

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jul 25, 2022

The Werkzeug limitation removed in #25270 can be removed now, when
Flask-login is fixed and 0.6.2 version is released that supports it.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member Author

potiuk commented Jul 26, 2022

Let's not merge this one (yet) flask login 0.6.2 break one of our tests (Google Oauth login). I can reliably reprosuce it but i need to find out if it is a real bug or test issue (i presume the latter - seems like we are mocking some internal call that have changed)

@potiuk potiuk marked this pull request as draft July 26, 2022 17:34
@potiuk
Copy link
Member Author

potiuk commented Jul 26, 2022

Actually, this turned to be real error @josh-fell and @jedcunningham - #25318

I think this one actually can have quite a bad effect on our users, I will follow up with flask-login maintainer to verify the actual scope of the problem.

As I see now, some of our users will likely have google openid auth backend stop working if they switch to Flask-Login 0.6.2 (And there is nothing to prevent them from doing so except constraints).

However in the meantime we should merge #25318 to stop main from failing

@potiuk potiuk force-pushed the update-to-flask-login-0-6-2 branch from b10f3f3 to 1c02af6 Compare July 27, 2022 15:10
@potiuk potiuk marked this pull request as ready for review July 27, 2022 15:11
The Werkzeug limitation removed in apache#25270 can be removed now, when
Flask-login is fixed and 0.6.2 version is released that supports it.
@potiuk potiuk force-pushed the update-to-flask-login-0-6-2 branch from 1c02af6 to 0f1c329 Compare July 27, 2022 18:20
@potiuk
Copy link
Member Author

potiuk commented Jul 27, 2022

Right. I also had to fix the tests because Werkzeug 2.2 suddenly started to return ' instead of ' 🤷

@potiuk potiuk merged commit dbbe9ac into apache:main Jul 27, 2022
@potiuk potiuk deleted the update-to-flask-login-0-6-2 branch July 27, 2022 20:08
potiuk added a commit that referenced this pull request Aug 4, 2022
The Werkzeug limitation removed in #25270 can be removed now, when
Flask-login is fixed and 0.6.2 version is released that supports it.

(cherry picked from commit dbbe9ac)
@potiuk potiuk added this to the Airflow 2.3.4 milestone Aug 5, 2022
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants