Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Yandex Dataproc cluster labels #29811

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

zinal
Copy link
Contributor

@zinal zinal commented Feb 28, 2023

Yandex Dataproc supports labels on its cluster resources to distinguish various projects and teams.
This commit adds support for specifying labels during cluster creation in the DataprocCreateClusterOperator, as part of the yandex provider.
yandexcloud provider dependency has to be updated to version 202, to support the labels function.

@boring-cyborg
Copy link

boring-cyborg bot commented Feb 28, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk potiuk force-pushed the yc-dataproc-labels branch from 52ea193 to dc3ceec Compare March 4, 2023 18:46
@potiuk
Copy link
Member

potiuk commented Mar 4, 2023

Rebased to rebuild with latest main/ account for failed job.

@eladkal
Copy link
Contributor

eladkal commented Mar 4, 2023

Please install and run pre-commits it will handle the static checks failure for you

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Apr 19, 2023
@potiuk
Copy link
Member

potiuk commented Apr 20, 2023

FYI, Yandex provider has been suspended from releases and we are not accepting any new PRS for yandex until the problem with protobuf is solved by Yandex maintainer. See #30667 - the issue to be solved is here and Yandex maintainers will have to resume the provider after the problem is fixed yandex-cloud/python-sdk#71

More information about suspending providers in https://github.com/apache/airflow/blob/main/airflow/providers/SUSPENDING_AND_RESUMING_PROVIDERS.rst

@github-actions github-actions bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Apr 21, 2023
@eladkal
Copy link
Contributor

eladkal commented May 22, 2023

I'm closing this PR since the provider is suspended.
Should the protobuf issue with yandex package is resolved we can reopen this PR

@eladkal eladkal closed this May 22, 2023
@zinal
Copy link
Contributor Author

zinal commented Aug 23, 2023

To my understanding, the provider is no longer suspended, as the protobuf4 support has been implemented in its dependencies.
Can you please re-open this PR?

@Taragolis Taragolis reopened this Aug 23, 2023
@potiuk
Copy link
Member

potiuk commented Aug 23, 2023

Yes. Should be fine to merge it now :)

@potiuk
Copy link
Member

potiuk commented Aug 23, 2023

Seems there was some accidental cancelling of post cache. All looks good. Merging

@potiuk potiuk merged commit 2ae1c10 into apache:main Aug 23, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 23, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@zinal zinal deleted the yc-dataproc-labels branch August 23, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants