Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Sqlalchemy queries to 2.0 style (Part 7) #32883

Merged
merged 10 commits into from
Aug 21, 2023

Conversation

phanikumv
Copy link
Contributor

This is a continuation of the effort to refactor the queries to sqlalchemy 2.0

related: #28723


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:core-operators Operators, Sensors and hooks within Core Airflow area:dev-tools area:providers area:webserver Webserver related Issues provider:celery labels Jul 27, 2023
@phanikumv phanikumv added full tests needed We need to run full set of tests for this PR to merge use public runners Makes sure that Public runners are used even if commiters creates the PR (useful for testing) labels Jul 27, 2023
@phanikumv phanikumv closed this Jul 27, 2023
@phanikumv phanikumv reopened this Jul 27, 2023
airflow/models/variable.py Outdated Show resolved Hide resolved
airflow/operators/subdag.py Outdated Show resolved Hide resolved
airflow/utils/scheduler_health.py Outdated Show resolved Hide resolved
airflow/www/security.py Outdated Show resolved Hide resolved
airflow/www/security.py Outdated Show resolved Hide resolved
@phanikumv phanikumv force-pushed the sqla_security branch 3 times, most recently from 231df10 to 53c4b13 Compare July 31, 2023 11:49
airflow/auth/managers/fab/models.py Outdated Show resolved Hide resolved
airflow/operators/subdag.py Outdated Show resolved Hide resolved
airflow/utils/scheduler_health.py Outdated Show resolved Hide resolved
airflow/www/security.py Outdated Show resolved Hide resolved
airflow/www/security.py Outdated Show resolved Hide resolved
airflow/www/security.py Show resolved Hide resolved
@phanikumv phanikumv force-pushed the sqla_security branch 7 times, most recently from c60f6a8 to 9d4d853 Compare August 8, 2023 08:31
@phanikumv phanikumv force-pushed the sqla_security branch 2 times, most recently from 72817e7 to 7e222c1 Compare August 10, 2023 04:46
@phanikumv phanikumv force-pushed the sqla_security branch 4 times, most recently from 17f2956 to 85a03e1 Compare August 16, 2023 14:17
@phanikumv phanikumv marked this pull request as ready for review August 17, 2023 08:03
@phanikumv phanikumv changed the title [WIP]:Refactor Sqlalchemy queries to 2.0 style (Part 7) Refactor Sqlalchemy queries to 2.0 style (Part 7) Aug 17, 2023
@phanikumv phanikumv requested a review from uranusjr August 17, 2023 09:44
Copy link
Contributor

@ephraimbuddy ephraimbuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments but generally LGTM

airflow/auth/managers/fab/models/__init__.py Show resolved Hide resolved
airflow/models/variable.py Show resolved Hide resolved
airflow/operators/subdag.py Show resolved Hide resolved
airflow/utils/sqlalchemy.py Show resolved Hide resolved
airflow/www/security.py Show resolved Hide resolved
airflow/www/security.py Show resolved Hide resolved
airflow/www/security.py Outdated Show resolved Hide resolved
@phanikumv phanikumv merged commit 4c4981d into apache:main Aug 21, 2023
1 check passed
@phanikumv phanikumv deleted the sqla_security branch August 21, 2023 13:34
@ephraimbuddy ephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Oct 2, 2023
@ephraimbuddy ephraimbuddy added this to the Airflow 2.8.0 milestone Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:core-operators Operators, Sensors and hooks within Core Airflow area:dev-tools area:providers area:webserver Webserver related Issues full tests needed We need to run full set of tests for this PR to merge provider:celery type:misc/internal Changelog: Misc changes that should appear in change log use public runners Makes sure that Public runners are used even if commiters creates the PR (useful for testing)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants