Move methods from security managers to FabAirflowSecurityManagerOverride
#33044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincbeck
requested review from
jhtimmins,
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
vincbeck
force-pushed
the
vincbeck/security_manager_override
branch
3 times, most recently
from
b90c0d0
to
04c83f7
Compare
vincbeck
added
the
use public runners
vandonr-amz
reviewed
Aug 2, 2023
vandonr-amz
approved these changes
Aug 2, 2023
vincbeck
force-pushed
the
vincbeck/security_manager_override
branch
from
04c83f7
to
319617a
Compare
vincbeck
force-pushed
the
vincbeck/security_manager_override
branch
from
319617a
to
0f031a8
Compare
o-nikolas
approved these changes
Aug 9, 2023
|
Can I have another review please? I am aware it is not the most interesting PR but this is needed. FYI: this is only moving code, there is no new code here, that should make the review easier :). @uranusjr @pierrejeambrun maybe 👼 |
|
I am sorry - I have just merged #33347 which has been important to be out for 2.7.0, and this one conflicts with it so if you please rebase witht the chnage of mine and ping me, I will review it quickly (also now when I am more familiar with recent changes you've done). Sorry - but 2.7. has been priority over the last few days |
|
Totally understandable 👌 No worries @potiuk. I just resolved the conflicts. If you can review it, that would be awesome 🥳 |
uranusjr
approved these changes
Aug 15, 2023
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 17, 2023
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of this PR is to move FAB related methods from security managers (AirflowSecurityManager, BaseSecurityManager and SecurityManager) to
FabAirflowSecurityManagerOverride. Since the effort is quite big, this PR is just a first step and more methods will be moved in separate PRs. This PR moves the most "obvious" methods to be moved. This will help to review the PR as well.Also, in order to avoid having one gigantic
FabAirflowSecurityManagerOverride, I decided to split it in different modules whichFabAirflowSecurityManagerOverrideinherits from. So far I created two modules:DBandoauth, each one defining methods related to either the database or Oauth.There is no new code in this PR, the changes are only code being moved around.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.