Fixing static checks for FabAirflowSecurityManagerOverride #33416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbegg
force-pushed
the
fix-status-check
branch
from
e7b8147
to
fc911d0
Compare
alexbegg
changed the title
Fixing static checks. FabAirflowSecurityManagerOverrideDb and FabAirflowSecurityManagerOverrideOauth were failing pydocstyle rule D205
alexbegg
force-pushed
the
fix-status-check
branch
from
fc911d0
to
596b3af
Compare
|
I fixed a typo in the commit message |
|
LGTM, I'll approve and merge it as soon as the CI goes green. Thanks for that. I made sure everything that was already committed passed, but there are bound to be a couple that were already in PR and got merged. |
ferruzzi
approved these changes
Aug 15, 2023
This was referenced Aug 15, 2023
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 17, 2023
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing static checks. FabAirflowSecurityManagerOverrideDb and FabAirflowSecurityManagerOverrideOauth were failing pydocstyle rule D205
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.