Add read only validation to read only fields #33413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add read only validation to DagRunEditForm and TaskInstanceEditForm read only fields.
ahidalgob
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
|
It would be nice to have a base airflow form Class so we could modify |
|
Could you check the failed static checks? Here is the doc: https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst |
|
Actually it is not related to this change, and it was fixed by #33416, I merge main |
uranusjr
reviewed
Aug 16, 2023
ahidalgob
force-pushed
the
read-only-validation
branch
from
66ec628
to
881f31c
Compare
ahidalgob
force-pushed
the
read-only-validation
branch
from
881f31c
to
c8ad87b
Compare
potiuk
approved these changes
Aug 16, 2023
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 17, 2023
* Add read only validation to read only fields Add read only validation to DagRunEditForm and TaskInstanceEditForm read only fields. * Improve docstring --------- Co-authored-by: Hussein Awala <hussein@awala.fr>
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 29, 2023
* Add read only validation to read only fields Add read only validation to DagRunEditForm and TaskInstanceEditForm read only fields. * Improve docstring --------- Co-authored-by: Hussein Awala <hussein@awala.fr> (cherry picked from commit b7a46c9)
ephraimbuddy
added
type:bug-fix
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add read only validation to DagRunEditForm and TaskInstanceEditForm read only fields.