Remove deprecated parts from Slack provider #33557
Conversation
Taragolis
force-pushed
the
slack-remove-remove-deprecated-stuff
branch
from
5b68092
to
34b3fcd
Compare
|
Ahhhh.... There is also exists deprecated operator SnowflakeToSlackOperator. |
Taragolis
force-pushed
the
slack-remove-remove-deprecated-stuff
branch
from
34b3fcd
to
c91df3a
Compare
Taragolis
force-pushed
the
slack-remove-remove-deprecated-stuff
branch
from
c91df3a
to
df69d1f
Compare
| @@ -27,6 +27,44 @@ | |||
| Changelog | |||
| --------- | |||
|
|
|||
| 8.0.0 | |||
There was a problem hiding this comment.
Since it's a breaking change we need also to add 8.0.0 to the provider yaml
| token: str | None = None, | ||
| slack_conn_id: str | None = None, | ||
| *, | ||
| slack_conn_id: str, |
There was a problem hiding this comment.
default_conn_name is not really used here.
There was a problem hiding this comment.
I guess it is never use any default connection ID
https://airflow.apache.org/docs/apache-airflow-providers-slack/stable/connections/slack.html#default-connection-ids
There was a problem hiding this comment.
I proposed a fix for it in this PR: #34548
There was a problem hiding this comment.
Better say feature. Without removal in this PR it was quite difficult to do that.
Let's move discussion in to your PR
There was a problem hiding this comment.
Yes, it's more an improvement of course. 😄
Most of the deprecations are made for about 1 year ago, I think it is a good time to remove it
In additional make slack hooks constructors are keyword arguments only. It would make further changes and deprecations more easier
ToDo:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.