Replace deprecated slack notification in provider.yaml with new one #33643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 23, 2023
The Slack Notification listed in provider.yaml for slack has been still using the deprecated version of it. Since the provider verification of ours did not check neither notifications nor warnings, it was not found before. Found in the attempt of adding new verification in apache#33608 then also detected by apache#33640 that improved existing verification.
potiuk
force-pushed
the
fix-slack-notification-deprecation
branch
from
369f5b9 to
c4aae7c
Compare
eladkal
approved these changes
Aug 23, 2023
|
this is one of the tasks that we didn't do yet in #31443 |
63 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Slack Notification listed in provider.yaml for slack has been still using the deprecated version of it. Since the provider verification of ours did not check neither notifications nor warnings, it was not found before.
Found in the attempt of adding new verification in #33608 then also detected by #33640 that improved existing verification.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.