Bring back broken "connection-type/hook-class-name" check #33662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One more fix to the provider.yaml pre-commit. It also missed the "hook-class-names" verification. This is why PinotHook has not been detected - this PR will only succeed after #33601 is merged. (But I wanted to add it now to have a proof that it would have detected it). |
hussein-awala
approved these changes
Aug 23, 2023
|
Why? |
Continuation of apache#33640 - there were one more wrong check in the provider, that missed "hook-class-names" check
potiuk
force-pushed
the
fix-wrong-hook-class-names-check
branch
from
c7fc828 to
b66a3eb
Compare
potiuk
changed the title
potiuk
changed the title
This is a much better title to not confuse it with the removed "hook-class-names" entry. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 24, 2023
This one completes review and check of provider.yaml verifications. There was one more check - for duplicates - that did not work as expected. It was hiding errors detected. This PR fixes it and also adds a bit more diagnostics messagese on what is actually being checked to give a bit more clue if some check is not doing what it is supposed to be doing. Follow up after apache#33662 and apache#33640
potiuk
added a commit
that referenced
this pull request
Aug 24, 2023
This one completes review and check of provider.yaml verifications. There was one more check - for duplicates - that did not work as expected. It was hiding errors detected. This PR fixes it and also adds a bit more diagnostics messagese on what is actually being checked to give a bit more clue if some check is not doing what it is supposed to be doing. Follow up after #33662 and #33640
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #33640 - there were one more wrong check in the provider, that missed "hook-class-names" check
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.