-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Referencing correct hooks for Apache Pinot #33601
Conversation
d08a310
to
bcd119f
Compare
@alexbegg thanks for contribution to Pinot Provider. Could you also add missing class attributes to
Examples: airflow/airflow/providers/postgres/hooks/postgres.py Lines 70 to 73 in 770228e
airflow/airflow/providers/google/common/hooks/base_google.py Lines 183 to 188 in 770228e
|
bcd119f
to
a528849
Compare
I have added those missing args, however I noticed some oddities with this provider:
Should this provider get actual operators, to avoid this confusion? |
The DBAPI- derived Hooks in provider are used by Maybe worth-while if someone (You ?) can make it clearer in the documentation if it is not clear enough. |
The `provider.yaml` for `airflow.providers.apache.pinot` provider was referencing a non-existing hook class of `PinotHook`, causing a warning during `providers_manager`'s sanity check. This corrects it to list both hooks of this provider.
a528849
to
070c381
Compare
I am not a regular user of Pinot so I am probably not the best to improve documentation for it. I attempted, but then stopped because of my unfamiliarity. I believe if the main point of this PR is to fix this bug then it will be good to go as is. |
The
provider.yaml
forairflow.providers.apache.pinot
provider was referencing a non-existing hook class ofPinotHook
, causing a warning duringproviders_manager
's sanity check. This corrects it to list both hooks of this provider.closes #33596
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.