Fix Azure Batch Hook instantation #33731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
hussein-awala
approved these changes
Aug 25, 2023
eladkal
approved these changes
Aug 25, 2023
Taragolis
approved these changes
Aug 25, 2023
The Hook instantiation for Azure Batch has been done in the constructor, which is wrong. This has been detected when apache#33716 added example dag and it started to fail provider imports as connection has beeen missing to instantiate it. The hook instantiation is now moved to cached property.
potiuk
force-pushed
the
fix-azure-batch-hook-instantiation
branch
from
964d763 to
c84eaaa
Compare
phanikumv
approved these changes
Aug 25, 2023
potiuk
commented
Aug 25, 2023
| @@ -162,6 +162,7 @@ def setup_method(self, method, mock_batch, mock_hook): | |||
| self.batch_client = mock_batch.return_value | |||
| self.mock_instance = mock_hook.return_value | |||
| assert self.batch_client == self.operator.hook.connection | |||
| assert self.batch_client == self.operator2_pass.hook.connection | |||
There was a problem hiding this comment.
Not sure why, but without that assertion in setup. the test TestAzureBatchOperator::test_execute_without_failures_2 fails with
self = <azure.batch.batch_auth.SharedKeyAuth object at 0xffffafb7fc10>, string_to_sign = 'POST\n\n\n425\n\napplication/json; odata=minimalmetadata; charset=utf-8\n\n\n\n\n\n\nocp-date:Fri, 25 Aug 2023 13:55:20 GMT\n/None/pools\napi-version:2023-05-01.17.0'
def _sign_string(self, string_to_sign):
> _key = self._key.encode('utf-8')
E AttributeError: 'NoneType' object has no attribute 'encode'
Maybe someone can explain it :)
There was a problem hiding this comment.
I guess it refers to mocking, previously it was instantiate immediately, but now you need to call it (cached).
I've plan also check entire provider for found the same instantiate connection in hook/operators/sensors
|
Tests are passing. Merging. |
This was referenced Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Hook instantiation for Azure Batch has been done in the constructor, which is wrong. This has been detected when #33716 added example dag and it started to fail provider imports as connection has beeen missing to instantiate it.
The hook instantiation is now moved to cached property.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.