Fix handling of single quotes in RedshiftToS3Operator
#35986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test case ensures that the RedshiftToS3Operator correctly handles a custom select_query containing single quotes. It validates that the operator generates a proper UNLOAD query that handles single quotes, thereby confirming its functionality in such scenarios.
boring-cyborg
bot
added
area:providers
provider:amazon-aws
|
CC @cjames23 |
uranusjr
reviewed
Dec 1, 2023
| @@ -141,8 +141,10 @@ def __init__( | |||
| def _build_unload_query( | |||
| self, credentials_block: str, select_query: str, s3_key: str, unload_options: str | |||
| ) -> str: | |||
| # Un-escape already escaped queries | |||
| select_query = select_query.replace("''", "'") | |||
There was a problem hiding this comment.
Would this break empty string literals…?
There was a problem hiding this comment.
Ouh! That's a good catch!
There was a problem hiding this comment.
I addressed it in 7d06f1e259a695fc68e16e50e9562f514dbb757d. I also added a unit test for this use case
eladkal
approved these changes
Dec 1, 2023
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue the work started in #32915.
Closes: #30287.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.