Lazy match escaped quotes in RedshiftToS3Operator
#40206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #35986,
RedshiftToS3Operator
began wrappingselect_query
in$$
to handle single quotes. Escaped single quotes (''
) are un-escaped using regex replacement for backwards compatibilty. The regex is greedy, however, and lines containing multiple strings inside of escaped single quotes only have the outermost quotes un-escaped.A query such as:
is modified to:
In this example, the operator succeeds but the results are unexpected.
This PR changes the regex pattern to match as few characters as possible, and adds test coverage for this case.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.