-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate obsolete AutoML operators and hooks #38635
Conversation
…and links (apache#38418)" This reverts commit 4a4eee1
65d52d2
to
9a9c1cc
Compare
9a9c1cc
to
653e838
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the prepared PR!
Our team has prepared a PR with the deprecation of AutoML operators as well as providing a VertexAI replacement for every operators that is deprecated. This is done to not just delete system tests, but show users how to use another operators from different services in gcp to achieve the same.
|
||
import warnings | ||
.. spelling:word-list:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a separate file that should be used to list all the words
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it occurred due to one of the pre commits
def deploy_model(self, **_): | ||
""" | ||
Deploy a model (deprecated). | ||
raise AirflowException( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For deprecations we need to use decorator @deprecated(reason="some reason here", category=AirflowProviderDeprecationWarning, action="error") that will raise error as well as outputting beautiful message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted for next time, thanks!
No problems :) |
depends on: #38633
Some of the AutoML operators and hooks have become practically unusable due to the shutdown of all AutoML domains but AutoML Translation. This PR deprecates them and replaces them with a raising of
AirflowException
. It also removes system tests that heavily depend on obsolete AutoML domains (created issue #38636 for rewriting them).^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.