Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate obsolete AutoML operators and hooks #38635

Closed

Conversation

shahar1
Copy link
Contributor

@shahar1 shahar1 commented Mar 30, 2024

depends on: #38633

Some of the AutoML operators and hooks have become practically unusable due to the shutdown of all AutoML domains but AutoML Translation. This PR deprecates them and replaces them with a raising of AirflowException. It also removes system tests that heavily depend on obsolete AutoML domains (created issue #38636 for rewriting them).


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@shahar1 shahar1 requested review from potiuk and ashb as code owners March 30, 2024 13:50
@boring-cyborg boring-cyborg bot added area:dev-tools area:production-image Production image improvements and fixes area:providers area:system-tests kind:documentation provider:google Google (including GCP) related issues labels Mar 30, 2024
@shahar1 shahar1 marked this pull request as draft March 30, 2024 14:05
@shahar1 shahar1 force-pushed the deprecate-specific-automl-methods branch 4 times, most recently from 65d52d2 to 9a9c1cc Compare March 30, 2024 15:44
@shahar1 shahar1 marked this pull request as ready for review March 30, 2024 15:50
@shahar1 shahar1 force-pushed the deprecate-specific-automl-methods branch from 9a9c1cc to 653e838 Compare March 30, 2024 16:21
@shahar1 shahar1 changed the title Deprecate specific AutoML operators and hooks Deprecate obsolete AutoML operators and hooks Mar 30, 2024
Copy link
Contributor

@VladaZakharova VladaZakharova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the prepared PR!
Our team has prepared a PR with the deprecation of AutoML operators as well as providing a VertexAI replacement for every operators that is deprecated. This is done to not just delete system tests, but show users how to use another operators from different services in gcp to achieve the same.


import warnings
.. spelling:word-list::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a separate file that should be used to list all the words

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it occurred due to one of the pre commits

def deploy_model(self, **_):
"""
Deploy a model (deprecated).
raise AirflowException(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For deprecations we need to use decorator @deprecated(reason="some reason here", category=AirflowProviderDeprecationWarning, action="error") that will raise error as well as outputting beautiful message

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted for next time, thanks!

@shahar1
Copy link
Contributor Author

shahar1 commented Apr 2, 2024

Thank you for the prepared PR!
Our team has prepared a PR with the deprecation of AutoML operators as well as providing a VertexAI replacement for every operators that is deprecated. This is done to not just delete system tests, but show users how to use another operators from different services in gcp to achieve the same.

No problems :)
I'll close this one, and I'll help reviewing #38673 after merging the reverting PR (#38633).
You are welcome to use anything from this PR in yours if you find it necessary.

@shahar1 shahar1 closed this Apr 2, 2024
@shahar1 shahar1 deleted the deprecate-specific-automl-methods branch June 12, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants