-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation of AutoML services: Add deprecation warnings and raise exceptions for already deprecated ones #38673
Conversation
ee79945
to
2aacd97
Compare
f75a35e
to
5331569
Compare
I think you need to rebase the PR. It's 52 commits behind and this is likely why it fails |
8d86abd
to
338ca37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start!
There's some work to do to finish it up (mostly adding tests and docstrings), and I hope that my comments will make sense - please ask if you have any questions.
I'd be happy if you could test the operator against an actual GCP project with enabled AutoML API to see if all functionalities work as expected :)
airflow/providers/google/cloud/hooks/vertex_ai/prediction_service.py
Outdated
Show resolved
Hide resolved
airflow/providers/google/cloud/hooks/vertex_ai/prediction_service.py
Outdated
Show resolved
Hide resolved
9f17725
to
1554e19
Compare
@molcay -> can you please rebase/resolve conflict and respond/mark as resolved all conversations that you think were resolved? |
c646a71
to
ec88665
Compare
cc: @VladaZakharova - there were some doubts for Google team about those deprecations - does this one look ok for you? |
ec88665
to
546199a
Compare
Hi! Thanks, yes, changes look good, LGTM |
@potiuk, |
da243a1
to
c7748ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good progress! :)
You resolved all of my comments, so you get a sincere approval from me.
One last step before merging - try to rebase and ensure that tests/providers/google/cloud/operators/test_automl.py
passes in the Non-DB tests, as currently they fail on the CI.
Make sure that objects are mocked properly in tests that you added or modified.
57b7fc4
to
fec27f3
Compare
Hey @shahar1 ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-reviewed, we're good to go :)
This PR is for raising exception for the deprecated services of AutoML (Tables, Vision, Video Intelligence, Natural Language) which are EoL or will be EoL soon.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.