-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provider Airbyte: breaking change, update provider to use Airbyte API Python SDK #41122
Provider Airbyte: breaking change, update provider to use Airbyte API Python SDK #41122
Conversation
@eladkal, can you take another look? Some tests are failing, but I can't determine if it’s due to my changes. |
9338ffd
to
06961bb
Compare
Before merging this change I'll run a final test with Airbye cloud and open source. |
9dd3a18
to
6c40cb1
Compare
Please do. If no further comments we are good to go |
You need to rebase/run pre-commit |
Running final test with local deployment and cloud. Gonna 💚 🚀 after finish these tests. |
🟢 Tests are working Need rebase and 🚀 |
5bf3e2f
to
ae2825a
Compare
c094c21
to
b3962a3
Compare
Wooohooo 🎉 !!! |
Great! any ETA on when will the new version be deployed in the python repository? Version is still 3.9.0 there: |
@baugarcia probably the next window of releases is in 3~4 weeks. But keep this to the maintainers to provide a better answer. |
Hello 👋, Airbyte has finally consolidated API access across the open-source, cloud, and enterprise versions.
This means all of them have a single method
client_id
andclient_secret
to authenticate to the API now.This pull request remove the dependency of
HttpHook
and uses theairbyte-api
Python SDK library to execute all operations (create job, cancel job, etc).The change is a breaking change to users as it removed the
api_type
parameter as it isn't required anymore.The new authentication method will become soon the unique method to auth to the API so this is a required changed.
Unit tests were updated to run using the new code.