-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix/livy-set-base-url #41658
bugfix/livy-set-base-url #41658
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
can you add a test for it please? |
on it |
UT added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for being receptive
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
We’re attempting to set
self.base_url
when it is not passed from outside. However, since the default value is an empty string, the conditionself.base_url is None
will never be true. This results in the log on line 161 being printed aswhich doesn’t make sense. Eventually,
self.get_conf
will be called inself.run_method
on line 163, so functionality-wise, everything works fine.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.