-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move to dag_run.logical_date from execution date in OpenLineage provider #41889
move to dag_run.logical_date from execution date in OpenLineage provider #41889
Conversation
dfe3d1f
to
76e9a97
Compare
Is it backwards-compatible with Airflow 2? |
@potiuk |
I know, just checking if it is ok to change it in the provider - which will be (for the next 6 months or so) only installed on Airflow 2 :) |
Simply execution_date and logical_date have different semantics, so my question is, if that will impact observed open-lineage events. And if so - whether it should be somehow explained in the changelog so that users are not surprised. |
@potiuk does it really have different semantics? From what I can find, it's essentially a rename: From AIP-39
Also in the docstring:
Basically, we want the same: the time when the DagRun is scheduled to be run, without consideration if it's actually going to run at that time, due to scheduler being backed up or other reason. |
Yep. You are right. I had confused it with "start/end interval" and other macros available in context, but logical_date and execution_date are really aliases. |
Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
76e9a97
to
d38e89c
Compare
Remove usage of deprecated
execution_date
in favor oflogical_date