Refactor AWS Auth manager user output #42454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS auth manager has incredible tooling to setup the required resources, however one piece needs to be done manually. This PR updates the docs and user output to make it more clear what needs to happen next. Removing the stacktrace (which usually indicates a critical failure in a piece of code) and replacing with a more clearly marked output message. Also update the docs to more clearly indicate that the script will most likely need user intervention.
boring-cyborg
bot
added
area:providers
kind:documentation
provider:amazon-aws
vincbeck
approved these changes
Sep 24, 2024
eladkal
approved these changes
Sep 25, 2024
96 tasks
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
AWS auth manager has incredible tooling to setup the required resources, however one piece needs to be done manually. This PR updates the docs and user output to make it more clear what needs to happen next. Removing the stacktrace (which usually indicates a critical failure in a piece of code) and replacing with a more clearly marked output message. Also update the docs to more clearly indicate that the script will most likely need user intervention.
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
AWS auth manager has incredible tooling to setup the required resources, however one piece needs to be done manually. This PR updates the docs and user output to make it more clear what needs to happen next. Removing the stacktrace (which usually indicates a critical failure in a piece of code) and replacing with a more clearly marked output message. Also update the docs to more clearly indicate that the script will most likely need user intervention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS auth manager has incredible tooling to setup the required resources, however one piece needs to be done manually. This PR updates the docs and user output to make it more clear what needs to happen next.
Removing the stacktrace (which usually indicates a critical failure in a piece of code) and replacing with a more clearly marked output message. Also update the docs to more clearly indicate that the script will most likely need user intervention.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.